Closed Bug 1211190 Opened 8 years ago Closed 8 years ago

Convert more hardcoded colors to CSS variables

Categories

(DevTools :: Shared Components, defect)

Product:
DevTools
Component:
Shared Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell
40 bytes, text/x-review-board-request
ntim
: review+
Details 
      No description provided.
Bug 1211190 -  UConvert hardcoded colors to CSS variables in devtools. r=bgrins
Attachment #8669363 - Flags: review?(bgrinstead)
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Summary of changes:
- Changed hardcoded theme colors to theme css vars
- canvasdebugger.css: Removed preprocessor variables and converted them to CSS vars
- webconsole.css: Changed old system colors to DevTools CSS variables (I used the closest existing var for each changed color)
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins
Attachment #8669363 - Attachment description: MozReview Request: Bug 1211190 - UConvert hardcoded colors to CSS variables in devtools. r=bgrins → MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Blocks: 1183280
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Jordan, can you have a look at the webaudioeditor and canvasdebugger changes?
Attachment #8669363 - Flags: review?(jsantell)
https://reviewboard.mozilla.org/r/21181/#review19269

Code looks great, way cleaner, both tools look the same in both light/dark, R+
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Web Audio and Canvas look great, thanks!
Attachment #8669363 - Flags: review?(jsantell) → review+
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

https://reviewboard.mozilla.org/r/21183/#review19275

Looks great, thanks!  Just one note to keep the console input looking the same in the light theme but let's land it after that

::: devtools/client/themes/webconsole.css:366
(Diff revision 3)
> +  background-color: #fff;

Should also re-add:

  border-color: ThreeDShadow;

to the light theme
Attachment #8669363 - Flags: review?(bgrinstead) → review+
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell
Attachment #8669363 - Attachment description: MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins → MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell
Attachment #8669363 - Flags: review?(jsantell)
Attachment #8669363 - Flags: review?(bgrinstead)
Attachment #8669363 - Flags: review+
Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Argh, mozreview
Attachment #8669363 - Flags: review?(jsantell)
Attachment #8669363 - Flags: review?(bgrinstead)
Attachment #8669363 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/ea6053144e51729eeb8fd23a0b88bcb103a3b803
Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ea6053144e51
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Blocks: dt-theme-cleanup
Depends on: 1239087
Product: Firefox → DevTools
Component: General → CSS and Themes
Component: CSS and Themes → Shared Components
You need to log in before you can comment on or make changes to this bug.