1211190 - Convert more hardcoded colors to CSS variables

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 -  UConvert hardcoded colors to CSS variables in devtools. r=bgrins

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Summary of changes:
- Changed hardcoded theme colors to theme css vars
- canvasdebugger.css: Removed preprocessor variables and converted them to CSS vars
- webconsole.css: Changed old system colors to DevTools CSS variables (I used the closest existing var for each changed color)

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Jordan, can you have a look at the webaudioeditor and canvasdebugger changes?

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

https://reviewboard.mozilla.org/r/21181/#review19269

Code looks great, way cleaner, both tools look the same in both light/dark, R+

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Web Audio and Canvas look great, thanks!

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

https://reviewboard.mozilla.org/r/21183/#review19275

Looks great, thanks!  Just one note to keep the console input looking the same in the light theme but let's land it after that

::: devtools/client/themes/webconsole.css:366
(Diff revision 3)
> +  background-color: #fff;

Should also re-add:

  border-color: ThreeDShadow;

to the light theme

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Comment 10

[Tim Nguyen :ntim]

Comment on attachment 8669363 [details]
MozReview Request: Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Argh, mozreview

Comment 11

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/fx-team/rev/ea6053144e51729eeb8fd23a0b88bcb103a3b803
Bug 1211190 - Convert hardcoded colors to CSS variables in devtools. r=bgrins, jsantell

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea6053144e51