Closed Bug 1211224 Opened 10 years ago Closed 9 years ago

Intermittent browser_ruleview_user-agent-styles.js | This test exceeded the timeout threshold. It should be rewritten or split up

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 wontfix, firefox45 fixed, firefox46 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 46
Tracking Flags:
Tracking Status
firefox44 --- wontfix
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: philor, Assigned: tromey)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

request longer timeout in browser_ruleview_user-agent-styles.js
1.01 KB, patch
pbro
: review+
Details | Diff | Splinter Review
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
This just seems to be a slow test. The try logs show the test finishing, then the test harness complaining about exceeding the timeout. So, this patch just requests a longer timeout.
Comment on attachment 8702336 [details] [diff] [review] request longer timeout in browser_ruleview_user-agent-styles.js The try run seemed reasonable to me.
Attachment #8702336 - Flags: review?(pbrosset)
Comment on attachment 8702336 [details] [diff] [review] request longer timeout in browser_ruleview_user-agent-styles.js Review of attachment 8702336 [details] [diff] [review]: ----------------------------------------------------------------- A lot of our tests seem to have started failing recently because they take too long to run. That's because test machines are sometimes under heavy load, and it's very unfortunate because sometimes there's just no way you can split the test in 2 smaller tests, which is what I would have suggested you did otherwise, but it doesn't make sense for this test. The tests sometimes run so slowly that there can literally be seconds before an event is emitted as the result of changing something in the UI. Also a lot of our tests are async, going to the server to get data etc. I wish we had more xpcshell unit tests to replace some of the longer ones, but we don't. So, anyway, I'm ok to simply increase the timeout for this test.
Attachment #8702336 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/ed866278df39
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
status-firefox44: affected → wontfix
status-firefox45: --- → affected
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: