Closed Bug 1211241 Opened 9 years ago Closed 9 years ago

Regression: Bananabread broken with recent builds

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox44 --- affected

People

(Reporter: lukebenes, Unassigned)

References

()

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The WebGL game BananaBread broke with recent commits. The textures are strange colors and the running/weapon animations are incorrect. 

https://developer.mozilla.org/en-US/demos/detail/bananabread

Here are the results of a mozregression:

2015-10-04T05:28:19: INFO : Narrowed inbound regression window from [d51440cc, 56db457a] (3 revisions) to [aa61d48e, 56db457a] (2 revisions) (~1 steps left)

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5b54831761b1&tochange=0010c0cb259e28faf764949df54687e3a21a2d0a

56db457aef33	Jeff Muizelaar — Bug 1179280. Update ANGLE from chromium/2214 to chromium/2466.
f99fe06748c3	Jeff Gilbert — Bug 1149728. Move CreateXForOffscreen functions. r=jrmuizel
aa61d48eb6ae	Mason Chang — Bug 1208636 - Adjust displayport size based on available system memory. r=kats
d51440cc7a2f	James Willcox — Bug 1191918 - Remove printf debugging r=me
Can you post a screenshot of the brokenness?
Flags: needinfo?(lukebenes)
I originally discovered the bug on a Windows box, but the screenshot was taken in Linux, so this is a cross-platform issue.
Flags: needinfo?(lukebenes)
Chrome also has the same problem. If you look at the console while the game is loading, there are errors about the shaders not compiling because of invalid '#pragma's.

I'm inclined to close this as won't fix.
Whiteboard: [gfx-noted]
Or move to tech evangelism to have the authors fix it on the shader side...
Are those pragmas in fact invalid? They used to compile without issue, was the previous behavior incorrect then?

If they are invalid, I can update BananaBread to fix that. I don't know a huge amount about shader language, though, so I'm not sure what is wrong in those shaders or how to fix them.

Note: this broke emscripten's browser.test_sdlglshader2 test as well, same issue.
It looks like ANGLE is being too strict and has since been fixed upstream. I'm planing on landing an update soon that should give us this fix.
This should be fixed now.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: