1211281 - [Metrics] AdvancedTelemetry does not retry properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Metrics, defect)

Description

[Tamara Hills [:thills]]

AdvancedTelemetry needs to handle error condition such as server is not available or incorrect URL more elegantly.

Needs to obey the RETRY_INTERVAL.  It currently does not.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] tamarahills:bugfix/1211281-handle-transmit-errors-advanced-telemetry > mozilla-b2g:master

Comment 2

[Tamara Hills [:thills]]

Comment on attachment 8669494 [details] [review]
[gaia] tamarahills:bugfix/1211281-handle-transmit-errors-advanced-telemetry > mozilla-b2g:master

Hi Russ,

I found this error in the retry mechanism after transmission fails either due to a timeout or an error.

Essentially, I changed it to start a new timer with the RETRY_INTERVAL vs. the REPORT_INTERVAL.

Would be great if you can feedback me.

Thanks,

-tamara

Comment 3

[Russ Nicoletti [:russn]]

Comment on attachment 8669494 [details] [review]
[gaia] tamarahills:bugfix/1211281-handle-transmit-errors-advanced-telemetry > mozilla-b2g:master

The change looks code. I left one comment about improving the readability of the code.

Comment 4

[Tamara Hills [:thills]]

Comment on attachment 8669494 [details] [review]
[gaia] tamarahills:bugfix/1211281-handle-transmit-errors-advanced-telemetry > mozilla-b2g:master

Hi Marshall,

This patch fixes the retry/timeout cases.  After it detects a retry/timeout it starts a timer for retry interval.

Thanks,

-tamara

Comment 5

[Iris Hsiao [:ihsiao]]

any update?

Comment 6

[Tamara Hills [:thills]]

Hi David,

Do you have time to review this?  I think Marshall must be pretty busy.

Thanks,
-tamara

Comment 7

[Marshall Culpepper [:marshall_law]]

Comment on attachment 8669494 [details] [review]
[gaia] tamarahills:bugfix/1211281-handle-transmit-errors-advanced-telemetry > mozilla-b2g:master

Sorry for lag on review Tamara, this looks good to me

Comment 8

[Tamara Hills [:thills]]

Try Run:  https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e57637bb331c8525cfc447d1c849c7988e549c2a
Commit:  https://github.com/mozilla-b2g/gaia/commit/9908a086b2819e6a3c76de937e3958177b5933b7

Comment 9

[Iris Hsiao [:ihsiao]]

Verified@
Build ID               20151106013953
Gaia Revision          1fb7e4b7904d577a1859b91269a85b363ddc2836
Gaia Date              2015-11-06 02:30:49
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/f073181a927d63ae7abac86e47cc3872ccac7275
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151106.005858
Firmware Date          Fri Nov  6 00:59:06 UTC 2015
Bootloader             s1

Verify result:
Telemetry retry properly based on the setting