Closed Bug 1211349 Opened 4 years ago Closed 4 years ago

[TV 2.5][Browser] Web page snapshot doesn't fill the entire card

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S11 (13Nov)

People

(Reporter: schien, Unassigned)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick] )

Attachments

(3 files, 1 obsolete file)

This is a follow-up bug for bug 1205325 comment #8. Currently the web page snapshot doesn't fill the entire card on homescreen and leaves a lot of empty space on both top and bottom of that card.
Attached patch fill-snapshot.patch (obsolete) — Splinter Review
corresponding patch
Component: Gaia::TV → Gaia::TV::Browser
Comment on attachment 8669540 [details] [diff] [review]
fill-snapshot.patch

Review of attachment 8669540 [details] [diff] [review]:
-----------------------------------------------------------------

f? @rexboy as an action item.
Attachment #8669540 - Flags: feedback?(rexboy)
Comment on attachment 8669540 [details] [diff] [review]
fill-snapshot.patch

Looks good to me.
- The issue of getting too small screenshot is not reproducible for me now. I got 823x420 on my nexus 7, which is enough (both width and height are larger than 336px), So we can land this. I can help if yo needed.
- If we found the issue of getting too small screenshot again we may need to reopen the bug.
Attachment #8669540 - Flags: feedback?(rexboy) → feedback+
Attachment #8669540 - Attachment is obsolete: true
Comment on attachment 8681838 [details] [review]
[gaia] schien:bug1211349 > mozilla-b2g:master

Now I have the time to move this forward by myself.
Attachment #8681838 - Flags: review?(rexboy)
Comment on attachment 8681838 [details] [review]
[gaia] schien:bug1211349 > mozilla-b2g:master

thank you!
Attachment #8681838 - Flags: review?(rexboy) → review+
https://github.com/mozilla-b2g/gaia/commit/8647b3676a384da2c8c4c57b6b6dcf09c899f4b5
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.