1211387 - Web content does not expect background-image set on <input> UA stylesheet, result strange gradient on e.g. Facebook

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: facebook.png

I proposed we remove all background gradients from <input> since lot of sites like Facebook does not expect to reset |background-image| property on the UA style sheet.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I believe simply remove the background first is better than waiting for bug 1157307 to be fixed.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

FWIW, Fennec removed the gradients a long time ago in bug 763671.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/content.css#114

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1211387.patch

I did not start fixing the reftest because I figured it's probably better to wait for one more persons acknowledgement on this issue on the fact that I am not bikeshedding.

I did not completely map the fixes done on Fennec in bug 763671 because the button style was replaced with an SVG file -- I don't know if we want to do that in B2G (or "Mozilla Foxfood") too.

Sorry for the unrelated reference too bug 1034832 comment 37.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8669585 [details] [diff] [review]
bug1211387.patch

Review of attachment 8669585 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with doing that if that doesn't break pages that use default unstyled controls. Eg. do we still display a simple <button> properly?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Try to find failing reftests

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ae9a448d8ed

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1211387.patch

I don't really know why bug 763671 set the background color of buttons as white but yes that's not going to work for B2G. There is the updated style in which colors are taken as the value at 50% position of all the gradients.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=77ed21439f09

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1211387.patch

Fixing all reftests and remove the resulting unexpected pass

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48fd35d228dd

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1211387.patch

Revert the changes on <button> and <select size=1> etc to retain the accordance.

The disabled selectors duplicates but I don't want to fix them in this bug because the patch should not changed too much with the r+'d one.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f41cc81994e0

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: bug1211387.patch

Restore reftests on buttons.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c421fdc7663a

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Looks good.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/e50f1d523996

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e50f1d523996