1211412 - Home panel tabs are misaligned on tablets.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: now.png

The home panel tabs (-> TabMenuStrip) are misaligned on the Nexus 9. See attached screenshots.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: previously.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

I assume that's a regression from bug 1185002?

Comment 3

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1211412 - Home panel tabs are misaligned on tablets. r=sebastian

Bug 1211412 - Home panel tabs are misaligned on tablets. r=sebastian

Comment 4

[Chenxia Liu [:liuche]]

This patch adds another attribute for whether the titles should wrap to the content or fill the titlebar. I'll need someone to test it, however - Sebastian, if you have the time, would you do that? I've uploaded an apk here, if it's easier:

http://people.mozilla.org/~liuche/bug-1211412/1-fillTitlebar.apk

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8669840 [details]
MozReview Request: Bug 1211412 - Home panel tabs are misaligned on tablets. r=sebastian

https://reviewboard.mozilla.org/r/21265/#review19223

Awesome! Introducing a new attribute is such a smart solution. \o/

::: mobile/android/base/home/TabMenuStripLayout.java:76
(Diff revision 1)
> +            button.setLayoutParams(new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT, 1.0f));

Shouldn't we set width to 0(dp) like we did in the XML?

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Tested it on the N9 and everything looks great again. :)

Comment 7

[Chenxia Liu [:liuche]]

> ::: mobile/android/base/home/TabMenuStripLayout.java:76
> (Diff revision 1)
> > +            button.setLayoutParams(new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT, 1.0f));
> 
> Shouldn't we set width to 0(dp) like we did in the XML?

Yeah...unfortunately LayoutParams are params instead of dimensions/values and you can't mix the two.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0fd50deb6ce9

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Chenxia Liu [:liuche] from comment #7)
> Yeah...unfortunately LayoutParams are params instead of dimensions/values
> and you can't mix the two.

Hu? But the constructor of LayoutParams accepts constants (WRAP_CONTENT/MATCH_PARENT) as well as fixed sizes?

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0fd50deb6ce9

Comment 12

[u549602]

Verified as fixed on latest Nightly build (44.0a1 / 2015-10-08) on Nexus 9 with Android 5.1.1

Comment 13

[Chenxia Liu [:liuche]]

Comment on attachment 8669840 [details]
MozReview Request: Bug 1211412 - Home panel tabs are misaligned on tablets. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1185002
[User impact if declined]: Titlebar on tablets has too much spacing
[Describe test coverage new/current, TreeHerder]: baked on nightly for a week, green Aurora try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf090ef5130f
[Risks and why]: low, baked on Nightly
[String/UUID change made/needed]: none

Comment 14

[Liz Henry (:lizzard)]

Looks like we need this as part of the work for bug 1185002 which we're uplifting to aurora.

Comment 15

[Liz Henry (:lizzard)]

Just realized this doesn't affect 42.
This would be good to verify on affected tablets.

Comment 16

[Liz Henry (:lizzard)]

Comment on attachment 8669840 [details]
MozReview Request: Bug 1211412 - Home panel tabs are misaligned on tablets. r=sebastian

UI tweak, tested ok on nightly, ok to uplift to aurora.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/14c2ffabafc3