Closed
Bug 1211467
Opened 9 years ago
Closed 9 years ago
Deprecated APIs in SuggestionsFragment
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(1 file)
|
4.44 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
> 1:12.49 /Users/sebastian/Projects/Mozilla/fx-team/mobile/android/base/../search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java:71: warning: [deprecation] onAttach(Activity) in Fragment has been deprecated
> 1:12.49 public void onAttach(Activity activity) {
> 1:12.49 ^
> 1:12.49 /Users/sebastian/Projects/Mozilla/fx-team/mobile/android/base/../search/java/org/mozilla/search/autocomplete/SuggestionsFragment.java:72: warning: [deprecation] onAttach(Activity) in Fragment has been deprecated
> 1:12.49 super.onAttach(activity);
> 1:12.49 ^
> 1:12.58 error: warnings found and -Werror specified
> 1:12.76 /Users/sebastian/Projects/Mozilla/fx-team/mobile/android/base/../search/java/org/mozilla/search/PreSearchFragment.java:66: warning: [deprecation] onAttach(Activity) in Fragment has been deprecated
> 1:12.76 public void onAttach(Activity activity) {
> 1:12.76 ^
> 1:12.76 /Users/sebastian/Projects/Mozilla/fx-team/mobile/android/base/../search/java/org/mozilla/search/PreSearchFragment.java:67: warning: [deprecation] onAttach(Activity) in Fragment has been deprecated
> 1:12.76 super.onAttach(activity);
> 1:12.76
|
Assignee | |
Comment 1•9 years ago
|
||
After a bunch of successful builds now this just showed up.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
OS: Unspecified → Android
Hardware: Unspecified → All
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8670251 -
Flags: review?(michael.l.comella)
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db5c62f6e20e
Comment on attachment 8670251 [details] [diff] [review] 1211467-onAttach.patch Review of attachment 8670251 [details] [diff] [review]: ----------------------------------------------------------------- Curious, this doesn't show up in the docs yet: http://developer.android.com/reference/android/support/v4/app/Fragment.html#onAttach%28android.content.Context%29
Attachment #8670251 -
Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/ca4229eea123
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•