1211490 - Crash: Navigating to Help settings menu when coming from private mode tab tray

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stephan Leroux [:sleroux]]

STR

1. Switch to private mode
2. Open Settings
3. Tap 'Help'

Expected
* Settings should close and a new tab appears and animates in with help page

Actual
App crashes

---------

The issue is with the BVC where we assume that all tabs that are opened using the openInNewTab call are normal tabs. Since we're in private mode, no tab is added to the list of tabs and the app crashes from the animation since there is no cell to animate from.

Comment 1

[Stephan Leroux [:sleroux]]

So this only happens when you have no private tabs open. If you have >= 1, it works fine.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1129

I don't like this patch - mostly because it exposes a fundamental flaw in our app architecture. To avoid crashing, I'm relying on the isPrivate flag from the tab tray to tell the BVC to open the tab in the correct mode to prevent the crash. Ideally the BVC shouldn't be doing this and we shouldn't be using the tab tray as our source of truth for if we're in private mode but a lot of that work will be part of https://bugzilla.mozilla.org/show_bug.cgi?id=1212021.

Comment 3

[Stephan Leroux [:sleroux]]

Merged