Closed
Bug 1211546
Opened 9 years ago
Closed 9 years ago
Re re re re re unbreak non-unified builds
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: efaust, Assigned: efaust)
Details
Attachments
(1 file)
7.40 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
As discussed.
Attachment #8669788 -
Flags: review?(terrence)
Comment 1•9 years ago
|
||
Comment on attachment 8669788 [details] [diff] [review] unbreakBarrierUnified.patch Review of attachment 8669788 [details] [diff] [review]: ----------------------------------------------------------------- WFM ::: js/src/gc/Barrier.cpp @@ +162,5 @@ > +template struct MovableCellHasher<GlobalObject*>; > +template struct MovableCellHasher<SavedFrame*>; > +template struct MovableCellHasher<ScopeObject*>; > + > +} // namesapce js remember to #define namesapce namespace
Attachment #8669788 -
Flags: review?(terrence) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b13aac696f7d for build bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=15202761&repo=mozilla-inbound
Flags: needinfo?(efaustbmo)
https://hg.mozilla.org/mozilla-central/rev/65478b9da2e7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Comment 6•9 years ago
|
||
Canceling ni? This needn't have been backed out in the first place, apart from sharing a push with a travesty.
Flags: needinfo?(efaustbmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•