Closed Bug 1211592 Opened 4 years ago Closed 4 years ago

The Copy Link and Email Link buttons show cursor:default, but the other buttons (Camera,Mic,Share Screen,Settings) show cursor:pointer

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Points:
1

Tracking

(firefox43 fixed, firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Iteration:
44.2 - Oct 19
Tracking Flags:
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jaws, Assigned: Mardak)

References

Details

Attachments

(3 files)

Screenshot
120.42 KB, image/png
Details
v1
1.21 KB, patch
jaws
: review+
Details | Diff | Splinter Review
for aurora (Mardak will land)
1.22 KB, patch
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image Screenshot — 
On the "Invite a friend to join you" screen of Hello, there is some inconsistency with the cursor when hovering over a button. See attachment for screenshot.
Attached patch v1 — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8669991 - Flags: review?(jaws)
Points: --- → 1
Depends on: 1184924
Comment on attachment 8669991 [details] [diff] [review]
v1

Review of attachment 8669991 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8669991 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/373f295a416eef9939ea8744887feb50ccf0bcc8
Bug 1211592 - The Copy Link and Email Link buttons show cursor:default, but the other buttons (Camera,Mic,Share Screen,Settings) show cursor:pointer [rs=jaws]
https://hg.mozilla.org/mozilla-central/rev/373f295a416e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Button doesn't have mouse pointer indicator that it can be clicked
[Describe test coverage new/current, TreeHerder]: N/a, css only
[Risks and why]: Low - css only
[String/UUID change made/needed]: None

I'll land this after bug 1184924 is uplifted.
Attachment #8670942 - Flags: approval-mozilla-aurora?
Iteration: --- → 44.2 - Oct 19
Comment on attachment 8670942 [details] [diff] [review]
for aurora (Mardak will land)

CSS changes for hello refresh in 43, approved for uplift
Attachment #8670942 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/faeb6b4444cc
Bug 1211592 - The Copy Link and Email Link buttons show cursor:default, but the other buttons (Camera,Mic,Share Screen,Settings) show cursor:pointer [rs=jaws, a=lizzard]
status-firefox43: --- → fixed
You need to log in before you can comment on or make changes to this bug.