Closed Bug 1211608 Opened 8 years ago Closed 8 years ago

talos: error when trying to extract minidump from browser hang on windows

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: parkouss, Assigned: parkouss)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher
40 bytes, text/x-review-board-request
jmaher
: review+
Details 
Basically, talos is calling wrongly mozcrash.kill_and_get_minidump, and that fail on windows. See bug 483968 for details.
Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher
Attachment #8669864 - Flags: review?(jmaher)
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Comment on attachment 8669864 [details]
MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher

https://reviewboard.mozilla.org/r/21277/#review19177

almost there!

::: testing/talos/talos/ttest.py:38
(Diff revision 1)
>          found = mozcrash.check_for_crashes(minidumpdir,

we pass in the variable 'minidump_dir', but use 'minidumpdir' and the remove the dir.
1) lets get the names to be the same
2) do we need to remove the minidumpdir still?
Attachment #8669864 - Flags: review?(jmaher)
Comment on attachment 8669864 [details]
MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher

Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher
Attachment #8669864 - Flags: review?(jmaher)
Comment on attachment 8669864 [details]
MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher

https://reviewboard.mozilla.org/r/21277/#review19179

almost.....!

::: testing/talos/talos/ttest.py:41
(Diff revision 2)
>          mozfile.remove(minidumpdir)

we need to change this name as well!
Attachment #8669864 - Flags: review?(jmaher)
Comment on attachment 8669864 [details]
MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher

Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher
Attachment #8669864 - Flags: review?(jmaher)
Comment on attachment 8669864 [details]
MozReview Request: Bug 1211608 - talos: error when trying to extract minidump from browser hang on windows. r=jmaher

https://reviewboard.mozilla.org/r/21277/#review19183

lets make this work!
Attachment #8669864 - Flags: review?(jmaher) → review+
Ok try looks green, so let's land it ! (note inbound is closed)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/42ee4f58e456
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.