1211643 - No toolbar-icons shown in SM

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Richard Marti (:Paenglab)]

The Lightning toolbarbutton-icons aren't shown in SM because they are now SVG's and SM doesn't like TB define the icon dimensions. This happens on all platforms except XP which is still using the old icons.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: SM-toolbarbutton-icon.patch

Philip, please can you test this with SM if this patch works?

I'm not 100% happy with this patch as we define the dimensions now on TB two times. But I don't see how we could fix this for SM only.

Comment 2

[Philip Chee]

Comment on attachment 8669910 [details] [diff] [review]
SM-toolbarbutton-icon.patch

This works except in the customize palette window. You probably need to style that too.

style chrome://global/content/customizeToolbar.xul chrome://calendar/ chrome://...

Comment 3

[Richard Marti (:Paenglab)]

Attachment: SM-toolbarbutton-icon.patch

Is this better for the customize panel?

Comment 4

[Philip Chee]

Comment on attachment 8672367 [details] [diff] [review]
SM-toolbarbutton-icon.patch

> +++ b/calendar/lightning/themes/common/lightning.css
> .....
> +@media not all and (-moz-os-version: windows-xp) {
> +  .calbar-toolbarbutton-1 .toolbarbutton-icon,
> +  #task-actions-toolbar > .toolbarbutton-1 .toolbarbutton-icon {
Please add:
  .msgHeaderView-button   .toolbarbutton-icon,

> Is this better for the customize panel?
Yes thanks. f+ with the addition above.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: SM-toolbarbutton-icon.patch

This should set all the sizes without interfering TB's styles.

Comment 6

[[:MakeMyDay]]

Richard, for which version is this report - only 4.6?

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8673816 [details] [diff] [review]
SM-toolbarbutton-icon.patch

Adding Aurora as I think where will be no new beta build before the next uplift. If I'm wrong then please approve also beta.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8673816 [details] [diff] [review]
SM-toolbarbutton-icon.patch

Review of attachment 8673816 [details] [diff] [review]:
-----------------------------------------------------------------

We decided to do one more beta mid cycle from now on, to test changes that may be backported to esr. r/a=philipp

Comment 9

[Philip Chee]

> +  #task-actions-toolbar > .msgHeaderView-button .toolbarbutton-icon {
The task actions toolbar all ready works without this new rule. I was referring to the Customize window for which you need something like:

  toolbarpaletteitem .msgHeaderView-button .toolbarbutton-icon,

(For some reason [.toolbarpaletteitem-box .msgHeaderView-button .toolbarbutton-icon] doesn't work)

Comment 10

[Richard Marti (:Paenglab)]

Attachment: SM-toolbarbutton-icon.patch

This should fix the sizes in customize window.

Comment 11

[rsx11m]

Comment on attachment 8675320 [details] [diff] [review]
SM-toolbarbutton-icon.patch

Can we please get this landed now that SeaMonkey 2.39 has been released already and depends on a working beta? Thanks.

Comment 12

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/1d7535f9bc10
http://hg.mozilla.org/releases/comm-aurora/rev/9d5bd15ae87d
http://hg.mozilla.org/releases/comm-beta/rev/4aba320b86ce

Comment 13

[Stefan Sitter [:ssitter]]

Lightning 4.5 is currently in comm-beta branch. Unfortunately the current version 4.7 is not yet available for selection in Bugzilla.

Comment 14

[Stefan Sitter [:ssitter]]

And keep in mind that Lightning release channel and repositories contains Lightning 4.0. 
But if I understand your request correctly you want the fix ported back only to Lightning 4.4.

Comment 15

[Richard Marti (:Paenglab)]

Yes, the initial SVG patch (bug 1153615) landed in 4.4.

Comment 16

[Carsten Hütter]

Just realized the missing icon after updating to SM 2.39.

Sorry for the noob user question: How can I apply the patch (Win7)?

Comment 17

[Richard Marti (:Paenglab)]

You need to rename the .xpi to .zip to unpack or work directly in it and then to add to the correct files (names are in the patch) the parts which have a + on line start (and then remove the + in the files). After saving the files you need to repack the previously unpacked content as zip and rename it again to .xpi. If all is done correctly you can install this xpi and it should work.

But the icons on main toolbar are still not visible and this needs a new patch in a new bug.

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8675320 [details] [diff] [review]
SM-toolbarbutton-icon.patch

I should probably get that flag renamed. For calendar, we use approval-calendar-release for the last ESR version. We don't do any releases from comm-release, so I don't think this needs approval. If you want this in 4.0.6, please re-request.

All milestones should be there now, please ping me if I missed one.

Comment 19

[Martin Schröder [:mschroeder]]

Resolving as fixed as the fix is in Lightning 4.5 and newer.

Comment 20

[rsx11m]

Per comment #18, please land this on comm-release (despite the not-quite-matching approval flag) as early as possible for SeaMonkey to pick this up with the 2.40 release coming up soon. Thanks!

Comment 21

[rsx11m]

(In reply to Martin Schröder [:mschroeder] from comment #19)
> Resolving as fixed as the fix is in Lightning 4.5 and newer.

Err, guess I've been just sleeping now. As long as there is a Lightning 4.5 beta (don't see any so far on AMO) at the time of release, this should work out of the box with SM 2.40, right?

So, what needs to be done to get a 4.5b1 build? After the last merge this patch is now included in comm-release, thus no further action should be necessary on that end.

Comment 22

[Philipp Kewisch [:Fallen][📱📆]]

I've uploaded 4.5b1 now, sorry for the delay. Note again, comm-release is not used by Lightning nor Thunderbird.
Lightning betas are not built from Seamonkey's comm-release, but from Thunderbird's comm-beta.

Comment 23

[rsx11m]

https://addons.mozilla.org/en-US/firefox/addon/lightning/versions/?page=1#version-4.5b1
Great, thanks! Sorry for my confusion, makes sense.