1211692 - Wheel of death when adding theme to a collection

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Amy Tsay [:amyt]]

http://imgur.com/AqaWVJP

First it hangs when you click Add to Collection, and when it loads and you click on the collection you want to add it too, the wheel just keeps spinning.

The themes eventually make it into the collection, but the wheel still spins.

Comment 1

[Andy McKay]

With the developer console I can see this is horribly slow:

https://www.dropbox.com/s/oynbzjosya2gcas/Screenshot%202015-10-05%2015.51.17.png?dl=0

Something looks amiss there, 5037 ms the first call, time out at 120,049 ms the second call.

Comment 2

[Valentina Virlics [:vvalentina], Ecosystem QA]

Also, when trying to make an addon search (from Collection's Add-on tab) after the same chars twice, no addons are listed, and the loading wheel is still "working".
Please see the screencast: http://screencast.com/t/jqcqRyXWf5 and let me know if another issue should be logged.
Verified on AMO-prod FF41(Win 7).

Comment 3

[Christopher Grebs [:cgrebs]]

PR https://github.com/mozilla/olympia/pull/829/

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/75d321a47f95f9c5ac079914a8f06d80cd050d95
Improve collections ajax list performance. (bug 1211692)

This uses a simple extra query to check if the addon
exists in a collection or not.

This avoids the for-loop and thus n queries on a (possibly) huge
list of addon ids.

Comment 5

[Valentina Virlics [:vvalentina], Ecosystem QA]

The issue from comment #2 is still reproducing: "wheel of death" is present if the same search chars are typed twice.
Please see the screencast: http://screencast.com/t/HeTLk02Cypw
Should I file another bug?

Comment 6

[Andy McKay]

(In reply to ValentinaP from comment #5)
> The issue from comment #2 is still reproducing: "wheel of death" is present
> if the same search chars are typed twice.
> Please see the screencast: http://screencast.com/t/HeTLk02Cypw
> Should I file another bug?

Yes its a different issue.

Comment 7

[Valentina Virlics [:vvalentina], Ecosystem QA]

based on comment #6 and comment #5 I'll mark this bug verified.
Postfix screencast: http://screencast.com/t/vBuwpLvK0
Closing bug.