Closed Bug 1211694 Opened 4 years ago Closed 4 years ago

dataLength added twice

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: dragana, Assigned: dragana)

Details

Attachments

(1 file)

I just notice that at:
http://hg.mozilla.org/mozilla-central/annotate/67adec79eb8a/netwerk/protocol/http/Http2Stream.cpp#l606

dataLength has been added twice.

There are no big consequences here only for correctness.
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attachment #8669969 - Flags: review?(mcmanus)
lgtm.. but have nick 2xcheck
Attachment #8669969 - Flags: review?(mcmanus) → review?(hurley)
Comment on attachment 8669969 [details] [diff] [review]
dataLengthAddedTwice.patch

Review of attachment 8669969 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8669969 - Flags: review?(hurley) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eab6f9c125cc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Backed out to see if it caused the crashes in bug 1213979.
https://hg.mozilla.org/mozilla-central/rev/11ff0ccb7d59
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla44 → ---
A separate fix for bug 1213979 has landed, so it's probably okay to land this again.
Keywords: checkin-needed
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d1d71aba0fbc - one of this change, this one or the other caused a perma failure like https://treeherder.mozilla.org/logviewer.html#?job_id=15945937&repo=mozilla-inbound

since i was unable to determine which of this 2 changes caused this i had to backout both to get the treen green again.
Flags: needinfo?(dd.mozilla)
This is almost guaranteed to be the other changeset, as that test isn't running h2, and this change only touches h2 code (not to mention it didn't cause this issue on its previous landing).
Flags: needinfo?(dd.mozilla)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9336ec74d12f
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.