1211716 - Duplicated shared theme entries in jar.mn

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Justin Dolske [:Dolske]]

Bug 1191442 landed after the jar.mn cleanup in bug 1204182 and bug 1191442.

Please move these lines:

   skin/classic/browser/usercontext/personal.svg       (../shared/usercontext/personal.svg)
   skin/classic/browser/usercontext/work.svg           (../shared/usercontext/work.svg)
   skin/classic/browser/usercontext/banking.svg        (../shared/usercontext/banking.svg)
   skin/classic/browser/usercontext/shopping.svg       (../shared/usercontext/shopping.svg)

From browser/theme/*/jar.mn to browser/theme/shared/jar.inc.mn.

Comment 1

[Justin Dolske [:Dolske]]

(In reply to Justin Dolske [:Dolske] from comment #0)
> cleanup in bug 1204182 and bug 1191442.

Oops, that should be "bug 1204182 and bug 1206883".

Comment 2

[:Gijs (he/him)]

Steven, are you currently working on this?

Comment 3

[Steven Englehardt [:englehardt]]

Thanks for the ping Gijs. It's a quick fix, so I'll be able to post a patch shortly.

Comment 4

[Steven Englehardt [:englehardt]]

Attachment: 1211716.patch

Comment 5

[:Gijs (he/him)]

Comment on attachment 8728224 [details] [diff] [review]
1211716.patch

Review of attachment 8728224 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review - looks good to me, thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8783699e2953

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8783699e2953