1211751 - Remove nsIChannelEventSink-forwarding from EventSource and FetchDriver

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: channelsink

Our XHR code has to jump through a bunch of hoops in order to forward the nsIChannelEventSink and the AsyncOnChannelRedirect function to notification-callbacks registered on the channel.

But the reason that it has to do that is because we expose the channel object to addons and chrome code before we register our own notification-callbacks. That means that addons/chrome code might have registered a notification callback which we need to make sure is still called.

However neither EventSource nor FetchDriver exposes the channel object to external code. So neither of these classes have to worry about notification callbacks being already registered.

So both these classes can simply handle the AsyncOnChannelRedirect function directly and not worry about calling any other nsIChannelEventSink implementations.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8670063 [details] [diff] [review]
channelsink

Review of attachment 8670063 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to break FetchDriver

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

FetchDriver was just missing the call to OnRedirectVerifyCallback. Everything else is unchanged.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f4692ac3882

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

https://hg.mozilla.org/integration/mozilla-inbound/rev/571d943ef5fffb60d6e6144e63a178adaf644576
Bug 1211751:  Remove nsIChannelEventSink-forwarding from EventSource and FetchDriver. It's never needed. r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/571d943ef5ff