1211791 - MozReview posts too many logs in Bugzilla when updating a large patchset

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: Extension, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

I sometimes have patchset consists of ~10 patches. Every time when I push a new version of that patchset, a terribly large number of logs (including comments and attachment changes) are posted to the bug page, which looks annoying.

I think all of those logs should be merged into one single comment.

I guess that would need change from Bugzilla side as well.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

I really hope this could be fixed soon, because one major advantage of MozReview for me is that I can submit a bunch of patches with one command, while the main disadvantage is that, it produces too many meaningless comments in bugzilla especially when there are too many patches, which makes me afraid to use MozReview.

Producing too many messages also makes it harder to locate truly important information. I did sometimes lose in the logs and miss some review comments.

Comment 3

[Mark Côté [:mcote]]

Agreed, I really want this fixed too.  I believe I can interrupt dylan's priorities for this.  I'll file an associated bug for the work on BMO (the bulk of it).

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Attachment: userscript to collapse updates

I just wrote a userscript which would merge successive updates together if:
* it has the same author as its previous update, and
* it is posted in 5min after its previous update, and
* both updates are a change/comment to an attachment

It is based on the Bugzilla experimental user interface, so it may not work with the tranditional user interface. (You can enable the experimental user interface in General Preferences.)

This should, to some extent, improve the readability of bug pages spammed by MozReview.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

dbaron, you may find it helpful.

Comment 6

[Mark Côté [:mcote]]

Oh nice, thanks!  Note that we're actively working on this right now.  Dylan has a BMO patch that will collapse all created/updated MozReview-attachment emails into a single email, and then he'll work on the supercollapse feature to collapse them all in the UI.  Should be ready within a week or so.

Comment 7

[Mark Côté [:mcote]]

Attachment: MozReview Request: rbbz: Use a single internal call for all attachment actions (bug 1211791). r?smacleod

Review commit: https://reviewboard.mozilla.org/r/29803/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29803/

Comment 8

[Mark Côté [:mcote]]

Attachment: MozReview Request: rbbz: Do all Bugzilla attachment actions together (bug 1211791). r?smacleod

This is another step toward switching to a single Bugzilla API call for
attachment actions.  We now prep all the attachment adds and updates and
then execute them sequentially.

Review commit: https://reviewboard.mozilla.org/r/29805/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29805/

Comment 9

[Mark Côté [:mcote]]

Added a blocker (bug 1237491) for the prep work so we can land it when it's ready, rather than waiting on bug 1226028 (this prep work should actually give a slight perf boost on its own for large commit sets).

Comment 10

[Mark Côté [:mcote]]

Note that the first part of this (bug 1237491) landed, which merges attachment/flag create/update bugmail into a single email.  However there are some other unintended side effects that were noted by glandium in bug 1259963.  I think we need to step back and see if this is really the best way to solve this.

Comment 11

[Mark Côté [:mcote]]

xidorn: we now collapse all comments related to the creation or update of MozReview attachments.  It's not perfect (bug 1226488 will make this even better) but it will remove some of the clutter.  Is this an improvement for you?  We could also get a bit more refined, e.g. tag attachment creation separately from update, but I'm not sure that's necessary.

Comment 12

[Xidorn Quan [:xidorn] UTC+11]

I'm not working on large patchsets recently, so I don't have a chance to verify whether the new experience is a big improvement for me, but yeah I think it should be better than before, and would be even better if multiple updates could be collapsed together. Thanks for working on this!

Comment 13

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.