Closed Bug 1211792 Opened 6 years ago Closed 6 years ago

The new private browser opened from task manager does not show the advice page or start page

Categories

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+)

VERIFIED FIXED
FxOS-S9 (16Oct)
blocking-b2g 2.5+

People

(Reporter: ashiue, Assigned: rakhavan)

References

()

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

STR:
1. Long press home button to go into tab view
2. Tap the new private tab button on the bottom left

Expected result:
1. The new opened private browser would show the advice page or start page(if already skipped the advice page)

Actual result:
1. The new opened private browser does not show the advice page or start page


Build info:
[Flame]
Build ID               20151005150202
Gaia Revision          1f226126dcba8af16c8db08556130b0bb04bb8d3
Gaia Date              2015-10-05 15:11:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/67adec79eb8a481d87721a10b2aa733020d326eb
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151005.182526
Firmware Date          Mon Oct  5 18:25:38 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151005211038
Gaia Revision          1f226126dcba8af16c8db08556130b0bb04bb8d3
Gaia Date              2015-10-05 15:11:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/67adec79eb8a481d87721a10b2aa733020d326eb
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151005.203012
Firmware Date          Mon Oct  5 20:30:20 UTC 2015
Bootloader
QA Whiteboard: [COM=Pin the Web]
blocking-b2g: --- → 2.5+
Priority: -- → P2
Whiteboard: [systemsfe]
Blocks: 1211748
Assignee: nobody → rakhavan
Attachment #8670528 - Flags: review?(kevingrandon)
Comment on attachment 8670528 [details] [review]
[gaia] jedireza:private-window-from-activity-manager > mozilla-b2g:master

Sounds like we're missing an integration test here that would catch this. The integration test would actually do some sanity checking that it's a proper private browser after pressing the button. We can do this later though, thanks for the fix.
Attachment #8670528 - Flags: review?(kevingrandon) → review+
Keywords: checkin-needed
Thanks for the fix. I didn't realize that "isMockPrivate" is what triggered the newtab page. We do have an integration test checking that a "private"-class AppWindow is instantiate, but nothing checks for the contents of the private window's new tab thing.
sorry had to revert this for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2980054&repo=b2g-inbound
Flags: needinfo?(rakhavan)
Summary: The new private browsr opened from task manager does not show the advice page or start page → The new private browser opened from task manager does not show the advice page or start page
This failed in the PR run as well. You have to make sure that link is all green there before marking a bug as checkin-needed:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0a81c6a32c1c4c197cda27f6b4477d8751e29533
Comment on attachment 8672194 [details] [review]
[gaia] jedireza:new-private-window-activity-manager > mozilla-b2g:master

Pardon the wait and the premature checkin-needed state change. I've created a new PR that re-enables the fix and updates the integration test.

Since this is a faux private window, I wasn't sure what else to check than to verify that we are on the URL we expect to be on (with the private=1 query param).
Flags: needinfo?(rakhavan)
Attachment #8672194 - Flags: review?(m)
Attachment #8672194 - Flags: review?(m) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/c24b1b32b64f97f2cbc62cea9c19efe0d9d78adf
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Verified on

[Flame]
Build ID               20151014150203
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151014.183316
Firmware Date          Wed Oct 14 18:33:28 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.