1211792 - The new private browser opened from task manager does not show the advice page or start page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect, P2)

Description

[Alison Shiue]

STR:
1. Long press home button to go into tab view
2. Tap the new private tab button on the bottom left

Expected result:
1. The new opened private browser would show the advice page or start page(if already skipped the advice page)

Actual result:
1. The new opened private browser does not show the advice page or start page


Build info:
[Flame]
Build ID               20151005150202
Gaia Revision          1f226126dcba8af16c8db08556130b0bb04bb8d3
Gaia Date              2015-10-05 15:11:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/67adec79eb8a481d87721a10b2aa733020d326eb
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151005.182526
Firmware Date          Mon Oct  5 18:25:38 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151005211038
Gaia Revision          1f226126dcba8af16c8db08556130b0bb04bb8d3
Gaia Date              2015-10-05 15:11:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/67adec79eb8a481d87721a10b2aa733020d326eb
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151005.203012
Firmware Date          Mon Oct  5 20:30:20 UTC 2015
Bootloader

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:private-window-from-activity-manager > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8670528 [details] [review]
[gaia] jedireza:private-window-from-activity-manager > mozilla-b2g:master

Sounds like we're missing an integration test here that would catch this. The integration test would actually do some sanity checking that it's a proper private browser after pressing the button. We can do this later though, thanks for the fix.

Comment 3

[Marcus Cavanaugh [:mcav]]

Thanks for the fix. I didn't realize that "isMockPrivate" is what triggered the newtab page. We do have an integration test checking that a "private"-class AppWindow is instantiate, but nothing checks for the contents of the private window's new tab thing.

Comment 4

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/a3bca2fc7ec3d1f73072d25d4bdf76a3ad0b083c

Comment 5

[Carsten Book [:Tomcat]]

sorry had to revert this for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2980054&repo=b2g-inbound

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

This failed in the PR run as well. You have to make sure that link is all green there before marking a bug as checkin-needed:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0a81c6a32c1c4c197cda27f6b4477d8751e29533

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:new-private-window-activity-manager > mozilla-b2g:master

Comment 8

[Reza Akhavan [:jedireza]]

Comment on attachment 8672194 [details] [review]
[gaia] jedireza:new-private-window-activity-manager > mozilla-b2g:master

Pardon the wait and the premature checkin-needed state change. I've created a new PR that re-enables the fix and updates the integration test.

Since this is a faux private window, I wasn't sure what else to check than to verify that we are on the URL we expect to be on (with the private=1 query param).

Comment 9

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/c24b1b32b64f97f2cbc62cea9c19efe0d9d78adf

Comment 10

[Alison Shiue]

Verified on

[Flame]
Build ID               20151014150203
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151014.183316
Firmware Date          Wed Oct 14 18:33:28 EDT 2015
Bootloader             L1TC000118D0

[Aries]
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1