Closed Bug 1211841 Opened 9 years ago Closed 9 years ago

Style off the main thread markers differently

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [polish-backlog][difficulty=medium])

Attachments

(2 files)

      No description provided.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [polish-backlog][difficulty=medium]
Attached patch v1Splinter Review
Lol this was fun
Assignee: jsantell → vporof
Status: ASSIGNED → NEW
Attachment #8671877 - Flags: review?(jsantell)
Comment on attachment 8671877 [details] [diff] [review]
v1

Review of attachment 8671877 [details] [diff] [review]:
-----------------------------------------------------------------

r+, be sure the processType and isMainThread are added to docs for common attributes for all markers (can be handled in the worker doc bug)
Attachment #8671877 - Flags: review?(jsantell) → review+
Attached patch v2Splinter Review
Addressed comments and rebased.
Attachment #8679391 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/594d0213bc5c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.