Closed
Bug 1211858
Opened 9 years ago
Closed 9 years ago
Add a hint for the Restyle label when the id is unavailable
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: vnicolas, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
1.69 KB,
patch
|
BenWa
:
review+
roc
:
review+
|
Details | Diff | Splinter Review |
This is sometime very useful when profiling an application that does not have ids on all elements. Just adding that has immediately make me discover bug 1211856. I first thought this was coming from the app side, before realizing this is a pure artifact from the platform.
Attachment #8670191 -
Flags: review?(bgirard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8670191 [details] [diff] [review] add.tagname.hint.to.the.profiler.for.restyle.patch Review of attachment 8670191 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, but please get a layout peer to review it.
Attachment #8670191 -
Flags: review?(bgirard) → review+
|
|
||
Comment 2•9 years ago
|
||
I also added this here which might give you a better descriptor overall: https://bugzilla.mozilla.org/show_bug.cgi?id=1181297
Using your descriptor sounds much better than just the tagName!
Attachment #8670191 -
Attachment is obsolete: true
Attachment #8670678 -
Flags: review?(roc)
Attachment #8670678 -
Flags: review?(bgirard)
Attachment #8670678 -
Flags: review?(roc) → review+
|
|
||
Updated•9 years ago
|
Attachment #8670678 -
Flags: review?(bgirard) → review+
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b71f15364923
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•