1211914 - Add nodejs/npm to MozillaBuild

Status: RESOLVED FIXED

(mozilla.org :: MozillaBuild, task)

Description

[Mark Banner (:standard8)]

As a developer, I should be able to use some of the high quality packages (such as eslint, react-tools, various css linters etc) whilst developing Firefox on Windows.

Devtools, Hello and Fennec have already enabled eslint, as well as using react in places.

Having nodejs included with MozillaBuild will simplify the setup for those users (as evidenced by the first time contributor having issues in bug 1206683), even if we haven't yet worked out all the details of enabling it in the build system.

Comment 1

[Mark Banner (:standard8)]

Also, here's what we suggest for developers to do on windows, after having installed MozillaBuild and then Node:

https://wiki.mozilla.org/Loop/Development#Windows_Specific

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I can take a look at this.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Gonna take another look at this for 2.3 at Standard8's request.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I was able to add nodejs 7.10.0 without any obvious issues. I then installed react-tools and eslint via |npm install -g <package>| and everything appears to work fine. However, I can't actually run ./mach eslint because it fails to find my nodejs installation (even though calling eslint directly works fine).

--------------------------------
$ ./mach eslint
nodejs v6.9.1 is either not installed or is installed to a non-standard path.
Please install nodejs from https://nodejs.org and try again.
--------------------------------

Looks like maybe setup_helper.py needs some updating? Right now, I've got it extracted to <mozillabuild>\nodejs.
https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/setup_helper.py#229

Also, are there any npm modules we want to ship by default with MozillaBuild?

Comment 5

[Mark Banner (:standard8)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Looks like maybe setup_helper.py needs some updating? Right now, I've got it
> extracted to <mozillabuild>\nodejs.
> https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/
> setup_helper.py#229

Do we have an env var for MozillaBuild's path? I'd be happy to add a hook for that in there as well.
 
> Also, are there any npm modules we want to ship by default with MozillaBuild?

I don't think there are - the eslint setup should install everything that is required.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

It's added to $PATH when the shell starts via https://hg.mozilla.org/mozilla-build/file/tip/msys/misc/profile-extravars.sh. We also export $MOZILLABUILD when start-shell.bat runs.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I put together a package that includes nodejs if you want to test it out locally too.
https://drive.google.com/file/d/0BxocUovXDf0iSXJwRXdsWG11NFE/view?usp=sharing

Comment 8

[Mark Banner (:standard8)]

I'll test it out tomorrow.

Comment 9

[Mark Banner (:standard8)]

It looks good, I'll fix finding node in the path in bug 1342715.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Thanks! Consider it included in the next release then :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/b4c5f97ad27a
Add nodejs/npm to MozillaBuild. r=Standard8