Closed
Bug 1211915
Opened 9 years ago
Closed 9 years ago
Fix nsinstall object directory when cross compiling
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox44 affected)
RESOLVED
FIXED
3.21
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: KaiE, Unassigned)
Details
Attachments
(1 file)
1.06 KB,
patch
|
mt
:
review+
|
Details | Diff | Splinter Review |
When cross compiling for Android, the NSS coreconf nsinstall binary is installed into one directory, but the later parts of the build expect them to be in a different directory. The reason is the COMPILER_TAG, which is different when building nsinstall (native gcc) and when building the other parts (cross compiler). I wonder if we could omit the COMPILER_TAG from the OBJDIR_NAME when we're cross compiling?
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8670264 -
Flags: review?(martin.thomson)
Comment 2•9 years ago
|
||
Comment on attachment 8670264 [details] [diff] [review] fix-cross.patch Review of attachment 8670264 [details] [diff] [review]: ----------------------------------------------------------------- I can't really confirm whether this is OK right now, but it looks rational.
Attachment #8670264 -
Flags: review?(martin.thomson) → review+
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/61ddc71ec898
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Target Milestone: --- → 3.21
You need to log in
before you can comment on or make changes to this bug.
Description
•