Closed Bug 1211918 Opened 6 years ago Closed 6 years ago

De-duplicate theme vars for JSON Viewer

Categories

(DevTools :: JSON Viewer, defect)

42 Branch
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

Attachments

(1 file)

JSON Viewer is currently using its own copy of CSS theme variables. It should use appropriate modules as soon as they are available (see bug 1210954)

Honza
Summary: De-duplicate themes vars for JSON Viewer → De-duplicate theme vars for JSON Viewer
Exposing variables.css and using it in JSON Viewer (content)

Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8674825 - Flags: review?(jryans)
Comment on attachment 8674825 [details] [diff] [review]
bug1211918-1.patch

Review of attachment 8674825 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8674825 - Flags: review?(jryans) → review+
Ryan, do you think the try push from comment #2 looks good?
I am always puzzled how to recognize non related failures...
 
Honza
Flags: needinfo?(jryans)
(In reply to Jan Honza Odvarko [:Honza] from comment #4)
> Ryan, do you think the try push from comment #2 looks good?
> I am always puzzled how to recognize non related failures...

Try is full of trash these days...  But, I think it looks good.
Flags: needinfo?(jryans)
Alright, thanks.

Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3da43ab3c203
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.