1211918 - De-duplicate theme vars for JSON Viewer

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

JSON Viewer is currently using its own copy of CSS theme variables. It should use appropriate modules as soon as they are available (see bug 1210954)

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1211918-1.patch

Exposing variables.css and using it in JSON Viewer (content)

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=016e525db2d4

Honza

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8674825 [details] [diff] [review]
bug1211918-1.patch

Review of attachment 8674825 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Ryan, do you think the try push from comment #2 looks good?
I am always puzzled how to recognize non related failures...
 
Honza

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jan Honza Odvarko [:Honza] from comment #4)
> Ryan, do you think the try push from comment #2 looks good?
> I am always puzzled how to recognize non related failures...

Try is full of trash these days...  But, I think it looks good.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alright, thanks.

Honza

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3da43ab3c203

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3da43ab3c203