Closed Bug 1211941 Opened 9 years ago Closed 8 years ago

nsICacheStorage.openTruncate should return a write handle, not just an ordinary handle

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox44 --- affected
firefox47 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

Attachments

(1 file)

v1
3.17 KB, patch
michal
: review+
Details | Diff | Splinter Review 
I think that, according the comment at [1], openTruncate implementations should also return a write handle.  When the entry is just released w/o any writings to it, it "hangs" around in a bad state.


[1] http://hg.mozilla.org/mozilla-central/annotate/89732fcdb0ba/netwerk/cache2/CacheEntry.cpp#l515
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attached patch v1 — — Splinter Review 
A very simple patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=321a956ae1c3
Attachment #8706939 - Flags: review?(michal.novotny)
Attachment #8706939 - Flags: review?(michal.novotny) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6043ab744d52
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: