1211961 - Opensearch plugin for support.mozilla.org often displays empty lines in suggestions

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect)

Description

[arni2033]

Attachment: screenshot - Opensearch plugin for support.mozilla.org often displays empty lines in suggestions.png

STR:   (Win7_64, Nightly 44, 32bit, ID 20151005030206, new profile, safe mode)
(A)
1. Open https://support.mozilla.org/en-US/search/suggestions?q=status , download file
2. View the file.
(B)
1. Open https://support.mozilla.org/ , click magnifier button in search bar, install search engine
2. Set that search engine as default one
3. Type "status" (or "1", or "3") in the search bar

Result:       (A), (B):   first five suggestions are empty
Expectations: 1) The server shouldn't return blank suggestions OR
              2) Browser should filter invalid suggestions from search engines

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll look into this. I was just looking at the opensearch stuff.

Comment 2

[arni2033]

// Just a note: currently first 5 items in server's response are NULLs. Others are valid suggestions.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Elaborating on comment #2 in case issues are ephemeral, it's returning this:

[
    "status",
    [
        null,
        null,
        null,
        null,
        null,
        ["What happened to the Status Bar?"],
        ["Group Status Report"],
        ["Block websites from storing site preferences or login status in Firefox"],
        ["Template:cloudstatus"],
        ["I'm having problems confirming my new Firefox Account"]
    ],
    [],
    [
        "https://support.mozilla.org[u'/questions/810754']",
        "https://support.mozilla.org[u'/questions/927895']",
        "https://support.mozilla.org[u'/questions/812205']",
        "https://support.mozilla.org[u'/questions/895977']",
        "https://support.mozilla.org[u'/questions/793959']",
        "https://support.mozilla.org[u'/en-US/kb/what-happened-status-bar']",
        "https://support.mozilla.org[u'/en-US/kb/group-status-report']",
        "https://support.mozilla.org[u'/en-US/kb/block-websites-storing-site-preferences']",
        "https://support.mozilla.org[u'/en-US/kb/templatecloudstatus']",
        "https://support.mozilla.org[u'/en-US/kb/im-having-problems-confirming-my-firefox-account']"
    ]
]

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/kitsune/pull/2669

There are still some issues, but I'm going to push those off until later.

Comment 5

[Michael Cooper [:mythmon]]

Will: I deployed PR 2669 to prod. Is that all you want to do here? Should we file another bug for further work?

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/kitsune/commit/51d92ac93d16690d05c4d6f9dd33787b950dcb98

I'll file a couple of bugs:

1. add tests for results for opensearch_suggestions view
2. rework opensearch_suggestions view to use the simple search search logic

I'll keep this open until I file those. I'll probably do it tomorrow.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #1212473 covers adding tests.

Bug #1212476 covers duplicate search code.

That's everything outstanding from this bug. Marking it as FIXED.