1211974 - While creating services from category 'profile-after-change', service for entry 'SpeechDispatcher Speech Synth', contract ID '@mozilla.org/synthspeechdispatcher;1' does not implement nsIObserver.

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this logging output in my Browser Console when starting up Nightly with a mostly-fresh profile:
{
While creating services from category 'profile-after-change', service for entry 'SpeechDispatcher Speech Synth', contract ID '@mozilla.org/synthspeechdispatcher;1' does not implement nsIObserver.
}

Seems like something's broken there.

Comment 1

[Daniel Holbert [:dholbert]]

This is with latest Nightly, 44.0a1 (2015-10-06), on 64-bit linux.

(eeejay, hoping you can take a look or know who would be the right person to take a look.)

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Implement nsIObserver in SpeechDispatcherService.

Just did what the warning said: Implemented nsIObserver. Although we don't directly observe anything. Olli, is this the right approach?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8670451 [details] [diff] [review]
Implement nsIObserver in SpeechDispatcherService.

Sure, that is what categorymanager seems to require.
Silly message though, since we explicitly handle the case when
nsIObserver isn't implemented
http://mxr.mozilla.org/mozilla-central/source/xpcom/components/nsCategoryManager.cpp#822

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe1ed0ded678

Comment 5

[Daniel Holbert [:dholbert]]

Thanks!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for robocop orange like https://treeherder.mozilla.org/logviewer.html#?job_id=15318924&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f700d1c3679f

Comment 7

[Eitan Isaacson [:eeejay]]

Not sure how/if that failure is related. These bits don't even build on Android.

Comment 8

[Ralph Giles (:rillian)]

Looks like you're getting along fine, but switching to a more specific component.

Comment 10

[Eitan Isaacson [:eeejay]]

https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=e20e50d06b1c

Comment 11

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85b1ce393c04

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85b1ce393c04