1211986 - Remove/improve blur performance for Top Site panel items

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stephan Leroux [:sleroux]]

The blur we render for each top site item is causing noticeable slow downs in frame rate of the application when rotating and while in the app switcher. We need to either improve the performance of the blurring or find an alternative option for displaying a top site item.

Comment 2

[Maria Popova]

Bulk changes to Aha cards. Filter on 'mpopova-aha-20151008' to find all matching messages.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1189

Comment 4

[Darrin Henein [:darrin]]

Comment on attachment 8678186 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1189

This is great! Looks awesome and feels snappy. Awesome work :)

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8678186 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1189

Nice, works well! Is this faster because the blur is only created once, whereas the UIVisualEffectView has to calculate the blur for every frame?

Also, does this mean we can support this effect now on iPad 2 and other older devices that didn't work with UIVisualEffectView?

Comment 7

[Stephan Leroux [:sleroux]]

Yup - this is faster because we're only running the blur code once and caching it into an image so the performance hit only happens on blur but after that it's equivalent of having a normal background image.

I'm not sure about iPad 2 and older devices. Unfortunately I don't have any of the unsupported older devices. :AaronMT, do you have an old iPad 2 to test on?

Comment 8

[Aaron Train [:aaronmt]]

I have an iPad 2. Everything is terribly slow.

Comment 9

[Stephan Leroux [:sleroux]]

Can you confirm the blur works on the iPad 2? Just worried about regressing since on iPad 2 the blur view was not supported.

Comment 10

[Stephan Leroux [:sleroux]]

Going to merge this in for testing in the next aurora on an iPad 2

Comment 11

[Stephan Leroux [:sleroux]]

a50a9162ef7645aeb7baaabbbcfb8507c175e3d2

Comment 12

[Aaron Train [:aaronmt]]

(In reply to Stephan Leroux [:sleroux] from comment #9)
> Can you confirm the blur works on the iPad 2? Just worried about regressing
> since on iPad 2 the blur view was not supported.

The device is on iOS 8 and not 9 (not my device and they don't want to upgrade). Everything in Firefox is slow on the iPad 2.