Closed Bug 1212007 Opened 9 years ago Closed 9 years ago

Pin dialog hidden style breaks accessibility.

Categories

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Accessibility
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access)

Attachments

(1 file)

[gaia] yzen:bug-1212007 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
apastor
: review+
Details | Review 
We need to make sure that pointer events none and opacity 0 is never used for hiding elements. These elements remain accessible to the screen reader. Instead visibility hidden should be used.

This case is also aggravated by the fact that this styling is used on the dialog which results in platform accessibility firing an unnecessary EVENT_DOCUMENT_LOAD_COMPLETE accessibility event (because the dialog is not hidden).

Caused by bug 1168955.
Summary: Pin dialog hidden style hidden style breaks accessibility. → Pin dialog hidden style breaks accessibility.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Attachment #8670432 - Flags: review?(timdream)
Comment on attachment 8670432 [details] [review]
[gaia] yzen:bug-1212007 > mozilla-b2g:master

I am not familiar with the new feature -- you should ask the original reviewer.
Attachment #8670432 - Flags: review?(timdream) → review?(apastor)
Instead of a see also, regression (or an incomplete feature) should be marked as a dependency instead.
Blocks: 1168955
See Also: 1168955 → 
Comment on attachment 8670432 [details] [review]
[gaia] yzen:bug-1212007 > mozilla-b2g:master

Sorry about that. That won't happen again! :)
Thanks for fixing it.
Attachment #8670432 - Flags: review?(apastor) → review+
https://github.com/mozilla-b2g/gaia/commit/b99837aa2294348317bcae68acabe71d9a83d774
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This one is part of 1209062, would you mark it 2.2r+ ?
Flags: needinfo?(whuang)
No longer blocks: 1209062
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
can we get a PR request for 2.2r ? :)
Comment on attachment 8670432 [details] [review]
[gaia] yzen:bug-1212007 > mozilla-b2g:master

Required for accessibility.
Attachment #8670432 - Flags: approval-gaia-v2.2r?(whuang)
Comment on attachment 8670432 [details] [review]
[gaia] yzen:bug-1212007 > mozilla-b2g:master

2.2R is not FL yet so I'm + it for all feature-b2g:2.2r+
Attachment #8670432 - Flags: approval-gaia-v2.2r?(whuang) → approval-gaia-v2.2r+
(In reply to Yura Zenevich [:yzen] from comment #8)
> Comment on attachment 8670432 [details] [review]
> [gaia] yzen:bug-1212007 > mozilla-b2g:master
> 
> Required for accessibility.

we still need a PR request for 2.2.r here or ?
Flags: needinfo?(yzenevich)
Comment on attachment 8670432 [details] [review]
[gaia] yzen:bug-1212007 > mozilla-b2g:master

Actually this pin the web is not part of v2.2r so this bug is not present in that branch. Removing the flags
Flags: needinfo?(yzenevich)
Attachment #8670432 - Flags: approval-gaia-v2.2r+
feature-b2g: 2.2r+ → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: