1212015 - Fix a couple of OOM handling issues in AsmJS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: fix-asm-failure

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8670399 [details] [diff] [review]
fix-asm-failure

Review of attachment 8670399 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the drive-by review, I was curious about what was going wrong here...

::: js/src/asmjs/AsmJSValidate.cpp
@@ +6401,5 @@
>      }
>  
>      AsmFunction* asmFunc = lifo.new_<AsmFunction>(lifo);
> +    if (!asmFunc)
> +        return false;

nice catch!

@@ +6485,5 @@
>      AsmModuleCompilerScope scope;
>      if (!CreateAsmModuleCompiler(m.compileInputs(), &scope))
>          return false;
>      ModuleCompiler& mc = scope.module();
> +    if (!mc.init())

CreateAsmModuleCompiler calls init() already.

@@ +6662,5 @@
>      if (!CreateAsmModuleCompiler(m.compileInputs(), &scope))
>          return false;
>      ModuleCompiler& mc = scope.module();
> +    if (!mc.init())
> +        return false;

ditto

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Benjamin Bouvier [:bbouvier] from comment #1)

> CreateAsmModuleCompiler calls init() already.

Oh, you fixed this yourself if bug 1181612, nice.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug1212015-asmjs v2

Even smaller patch this time.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8670410 [details] [diff] [review]
bug1212015-asmjs v2

Review of attachment 8670410 [details] [diff] [review]:
-----------------------------------------------------------------

r="whatever Benjamin said"

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc9b0c250d3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ddc9b0c250d3