1212045 - Status bar color does not update to correct state after task manager closes

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect, P2)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue

The status bar color does not automatically update to make itself readable on the screen underneath after killing an app. This will be noticeable to user after they kill the Browser or the Settings app, because these 2 apps show a gray status bar, and upon killing them it would show a gray status bar over the Homescreen.

STR:
1) Open Browser or Settings app
2) Long press the Home button to bring up task manager
3) Kill the browser app, and observe the status bar

Expected: Status bar should be white if at step 3 it returns user to Homescreen

Actual: Status bar is gray. It turns itself into white again if user starts scrolling on Homescreen.

Video demonstrating the issue:
https://www.youtube.com/watch?v=L8GG09DKGg0

Attaching a logcat.

Repro rate: 5/5

Device: Aries 2.5
BuildID: 20151006110922
Gaia: 60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gecko: 89732fcdb0baca70e8b7a25a2725117113f0db80
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.5
BuildID: 20151006030203
Gaia: 60cdaa3d3424db3432dc903e7f9c6c8fa099c06d
Gecko: 3edc8d4a1e198314f5d7ebd2967b85842beef602
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue does not occur on Flame 2.2. Status bar color auto updates upon killing browser or settings app.

Device: Flame 2.2
BuildID: 20151006032504
Gaia: 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583
Gecko: fc588eb28eab
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

[Blocking Requested - why for this release]:
Regression of usability on the status bar.  Lets get a window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.5
BuildID: 20151002110339
Gaia: 51b91e4d3e692aeb6e5e7cff877a921300af20b2
Gecko: d77a41837bdecdc8d521dd6fdac5d00a5813c879
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

First Broken
Device: Flame 2.5
BuildID: 20151002121840
Gaia: 258d6da499c384d62b865fccafb6ec208f14b67f
Gecko: 041415e9df0b6d24353e3aa187eed02b27071185
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 51b91e4d3e692aeb6e5e7cff877a921300af20b2
Gecko: 041415e9df0b6d24353e3aa187eed02b27071185

Last Working Gecko First Broken Gaia - repro
Gaia: 258d6da499c384d62b865fccafb6ec208f14b67f
Gecko: d77a41837bdecdc8d521dd6fdac5d00a5813c879

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/51b91e4d3e692aeb6e5e7cff877a921300af20b2...258d6da499c384d62b865fccafb6ec208f14b67f

This issue is caused by changes made in Bug 1209402.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] mcav:statusbar-update-from-task-manager > mozilla-b2g:master

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8672139 [details] [review]
[gaia] mcav:statusbar-update-from-task-manager > mozilla-b2g:master

This patch moves emitting "cardviewclosed" to after the task manager fully closes. In other words, "cardviewclosed" needs to be emitted after taskManager.setActive(false), otherwise the statusbar thinks taskManager is still active when it updates in response to cardviewclosed.

This addresses a number of related problems reported in bugs duped to this one. For this bug specifically, there's still a brief delay in updating the statusbar after leaving the task manager, but that goes away when including your repaint bug 1185553 fix.

Comment 9

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/9d51123753ca63ad53958a843825ba490ac8391f

Comment 10

[Tony(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aries KK 2.5 by the STR in comment 0.

Actual results: Status bar will be white if at step 3 it returns user to Homescreen.
See attachment: verified_Aries KK_v2.5.3gp.
Reproduce rate: 0/10.

Device: Flame KK 2.5 (Pass)
Build ID               20151014150203
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151014.183316
Firmware Date          Wed Oct 14 18:33:28 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1

Comment 11

[Tony(Leave from Mozilla)]

Attachment: verified_Aries KK_v2.5.3gp