Closed Bug 1212056 Opened 9 years ago Closed 9 years ago

Add virtual dtor to WindowsWifiScannerInterface

Categories

(Core :: Networking, defect)

42 Branch
Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: maksqwe1, Assigned: maksqwe1)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151001142456

Steps to reproduce:

WindowsWifiScannerInterface is an interface for WinWifiScanner and WinXPWifiScanner. Which is used in nsWifiMonitor:
nsAutoPtr<WindowsWifiScannerInterface> mWinWifiScanner;



Actual results:

Memory leak when mWinWifiScanner is deleted.
Component: Untriaged → Networking
Product: Firefox → Core
Attached patch PatchSplinter Review
OS: Unspecified → Windows
Comment on attachment 8670454 [details] [diff] [review]
Patch

Review of attachment 8670454 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding and fixing this! For future reference, it can be easy to overlook patches that are attached to bugs without the `review` flag set to `?` and a reviewer selected.
Attachment #8670454 - Flags: review+
Assignee: nobody → maksqwe1
https://hg.mozilla.org/mozilla-central/rev/a928fa9221a3
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: