1212072 - Add unit tests for invitation code

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[[:MakeMyDay]]

We're currently lacking unit tests for the email invitation code. To get this easier to test, some of ccode from calItipEmailTransport.js should move to ltnInvitationUtils.jsm.

Comment 1

[[:MakeMyDay]]

Attachment: AddUnitTestsForInvitationCode-V1.diff

This patch extracts some code from calItipEmailTransport to ltnInvitationUtils ands adds tests for those and all the existing functions in ltnInvitationUtils. apart from that, the patch contains a fix for an error in the codes which takes care of decorating removals/modifications in the overlay code, that got obvious while writing the tests.

If you want to run that test, you should have applied the patch for bug 1212075 before.

Comment 2

[[:MakeMyDay]]

Too quick: also the patch for bug 1205287 is required to run the test successfully.

Comment 3

[[:MakeMyDay]]

Attachment: AddUnitTestsForInvitationCode-V2.diff

Updated patch with finally passing test for all platforms.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8688577 [details] [diff] [review]
AddUnitTestsForInvitationCode-V2.diff

Review of attachment 8688577 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, please check whitespaces though.

Comment 5

[[:MakeMyDay]]

https://hg.mozilla.org/comm-central/rev/3beb2c1f67ec

Comment 6

[:aceman]

On trunk, the new tests fail on all platforms: https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=fbf673d04af4

Comment 7

[[:MakeMyDay]]

Yes, there is bug 1230766 filed for that. The fix will be landing bug 1212075.