Closed Bug 1212072 Opened 7 years ago Closed 7 years ago

Add unit tests for invitation code

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

References

Details

Attachments

(1 file, 1 obsolete file)

We're currently lacking unit tests for the email invitation code. To get this easier to test, some of ccode from calItipEmailTransport.js should move to ltnInvitationUtils.jsm.
This patch extracts some code from calItipEmailTransport to ltnInvitationUtils ands adds tests for those and all the existing functions in ltnInvitationUtils. apart from that, the patch contains a fix for an error in the codes which takes care of decorating removals/modifications in the overlay code, that got obvious while writing the tests.

If you want to run that test, you should have applied the patch for bug 1212075 before.
Attachment #8670491 - Flags: review?(philipp)
Too quick: also the patch for bug 1205287 is required to run the test successfully.
Updated patch with finally passing test for all platforms.
Attachment #8670491 - Attachment is obsolete: true
Attachment #8670491 - Flags: review?(philipp)
Attachment #8688577 - Flags: review?(philipp)
Blocks: ltn47
Comment on attachment 8688577 [details] [diff] [review]
AddUnitTestsForInvitationCode-V2.diff

Review of attachment 8688577 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, please check whitespaces though.
Attachment #8688577 - Flags: review?(philipp) → review+
https://hg.mozilla.org/comm-central/rev/3beb2c1f67ec
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Depends on: 1230767
On trunk, the new tests fail on all platforms: https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=fbf673d04af4
Yes, there is bug 1230766 filed for that. The fix will be landing bug 1212075.
Depends on: 1230766, 1212075
No longer depends on: 1230767
You need to log in before you can comment on or make changes to this bug.