Closed
Bug 1212083
Opened 9 years ago
Closed 9 years ago
Remove direct call functionality from Loop's frontend
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox44 fixed)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [web sharing])
User Story
Acceptance criteria: - All direct call views related views removed. - All associated css removed. - All redundant strings removed. - Views removed from ui-showcase. - Any redundant prefs removed from firefox.js Engineering notes: - Direct call views live in conversationViews.jsx -- FailureInfoView will need to move from conversationViews.jsx to roomViews.jsx - Store is in conversationStore.js - websocket.js and client.js should also be able to be removed - conversation.jsx will need adjusting to not handle the direct calls.
Attachments
(2 files)
|
109.15 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
|
180.45 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Once bug 1212074 has remove the access to direct calls from the panel, we should remove the direct call functionality from the conversation window. See user story for more details. A follow-up bug will remove the functionality from the backend.
|
Assignee | |
Updated•9 years ago
|
Rank: 12
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → standard8
|
|
Assignee | |
Comment 1•9 years ago
|
||
This is the first of two parts. This part removes all the reliance/links on the direct call code. It also moves the FailureInfoView from the conversationViews to the roomViews as that's where it is needed now.
Attachment #8671595 -
Flags: review?(mdeboer)
|
|
Assignee | |
Comment 2•9 years ago
|
||
This does the actual file removals.
Attachment #8671597 -
Flags: review?(mdeboer)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8671595 [details] [diff] [review] Part 1. Remove the direct calls UI from Loop. Review of attachment 8671595 [details] [diff] [review]: ----------------------------------------------------------------- You're also good at removing things :)
Attachment #8671595 -
Flags: review?(mdeboer) → review+
|
|
||
Updated•9 years ago
|
Attachment #8671597 -
Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/e284a39210d2 https://hg.mozilla.org/integration/fx-team/rev/9780a6a015da
https://hg.mozilla.org/mozilla-central/rev/e284a39210d2 https://hg.mozilla.org/mozilla-central/rev/9780a6a015da
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Updated•9 years ago
|
Iteration: --- → 44.2 - Oct 19
You need to log in
before you can comment on or make changes to this bug.
Description
•