Closed Bug 1212090 Opened 10 years ago Closed 8 years ago

IconsHelper has too many depencencies

Categories

(Firefox OS Graveyard :: Gaia::System::System UI, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::System UI
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: sfoster, Unassigned)

Details

(Whiteboard: [systemsfe])

shared/js/icons_helper.js provides utility functions for looking up the appropriate icon URL and kinda facilitates using that information to put icons on the screen. But, it depends on Icon (shared/js/homescreens/icon.js) which in turn depends on GridIconRenderer (shared/elements/gaia_grid/js/grid_icon_renderer.js) .. which is a bit insane. IconsHelper should really be able to exist stand-alone. Perhaps Icon could be folded into IconsHelper. And refactored slightly to allow passing a post-processor like GridIconRenderer.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.