Open Bug 1212133 Opened 4 years ago Updated 9 months ago

crash in mozilla::a11y::DocAccessible::RemoveDependentIDsFor(mozilla::a11y::Accessible*, nsIAtom*)

Categories

(Core :: Disability Access APIs, defect, critical)

Unspecified
Linux
defect
Not set
critical

Tracking

()

REOPENED
Tracking Status
firefox44 --- fixed
firefox45 --- wontfix
firefox48 --- wontfix
firefox49 --- wontfix
b2g-v2.5 --- fixed
firefox50 --- wontfix
firefox64 --- affected
firefox65 --- affected

People

(Reporter: tbsaunde, Assigned: surkov)

Details

(Keywords: crash, Whiteboard: a11y:crash-tree)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-840b56a3-64c0-4a40-9af4-d42822151006.
=============================================================
A couple on Windows involving OOM:
report bp-5ad10efa-6833-413d-af8f-500812151009.
report bp-b0370a1b-6b09-4548-9c89-5e4372151007.

These crashes are currently very infrequent.
Crash Signature: [@ mozilla::a11y::DocAccessible::RemoveDependentIDsFor(mozilla::a11y::Accessible*, nsIAtom*)] → [@ mozilla::a11y::DocAccessible::RemoveDependentIDsFor(mozilla::a11y::Accessible*, nsIAtom*)] [@ mozilla::a11y::DocAccessible::RemoveDependentIDsFor]
Alex can you recreate this in fb messenger?
Flags: needinfo?(surkov.alexander)
(In reply to David Bolter [:davidb] from comment #4)
> Alex can you recreate this in fb messenger?

no so far, I'll try on Windows, when I'll set up the machine
Flags: needinfo?(surkov.alexander)
I'm trying to remember the exact steps that got me here. I think I typed someone's name in the search box, selected the name and then began typing the message. After about 1~2 seconds it crashed.
Assignee: nobody → surkov.alexander
Surkov, this bug is a top crasher on Beta44. Hoping that we can get a fix/repro available soon. Thanks!
Flags: needinfo?(surkov.alexander)
(In reply to Ritu Kothari (:ritu) from comment #7)
> Surkov, this bug is a top crasher on Beta44. Hoping that we can get a
> fix/repro available soon. Thanks!

is the issue different from bug 1213281 which has been landed on release and aurora channels?
Flags: needinfo?(surkov.alexander)
Surkov, bug 1213281 landed on Aurora44 (which is now Beta44) so this bug is a different issue.
Flags: needinfo?(surkov.alexander)
Attached patch patchSplinter Review
Flags: needinfo?(surkov.alexander)
Attachment #8704270 - Flags: review?(dbolter)
Attachment #8704270 - Flags: review?(dbolter) → review+
Comment on attachment 8704270 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:aria-owns implementation initially landed on this beta
[User impact if declined]:top crash
[Describe test coverage new/current, TreeHerder]:not covered
[Risks and why]: small, couple of null checks
[String/UUID change made/needed]:no
Attachment #8704270 - Flags: approval-mozilla-beta?
Alexander, could you please describe the test coverage you did on this patch? Was it locally and manually tested to ensure there were no obvious regressions? I will not be able to take a patch with "no test coverage" to Beta44.
Flags: needinfo?(surkov.alexander)
(In reply to Ritu Kothari (:ritu) from comment #13)
> Alexander, could you please describe the test coverage you did on this
> patch? Was it locally and manually tested to ensure there were no obvious
> regressions? I will not be able to take a patch with "no test coverage" to
> Beta44.

I meant there's no test coverage for the patch, because no steps to reproduce. Try server build was ok, so all mochiteset passed. Thus no obvious regressions.
Flags: needinfo?(surkov.alexander)
Comment on attachment 8704270 [details] [diff] [review]
patch

not null checks, beta44+
Attachment #8704270 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Surkov, could you also request uplift to Aurora45?
Flags: needinfo?(surkov.alexander)
(In reply to Ritu Kothari (:ritu) from comment #16)
> Surkov, could you also request uplift to Aurora45?

beta and aurora have a quite different code, aurora might not need a patch like this
Flags: needinfo?(surkov.alexander)
it's not an issue for nightly, if it should be fixed for 44, then the null check should help
Flags: needinfo?(surkov.alexander)
Crash volume for signature 'mozilla::a11y::DocAccessible::RemoveDependentIDsFor':
 - nightly (version 50): 4 crashes from 2016-06-06.
 - aurora  (version 49): 10 crashes from 2016-06-07.
 - beta    (version 48): 30 crashes from 2016-06-06.
 - release (version 47): 0 crashes from 2016-05-31.
 - esr     (version 45): 0 crashes from 2016-04-07.

Crash volume on the last weeks:
            W. N-1  W. N-2  W. N-3  W. N-4  W. N-5  W. N-6  W. N-7
 - nightly       0       0       1       1       0       1       0
 - aurora        0       2       1       0       2       3       1
 - beta          5       4       2       5       4       4       4
 - release       0       0       0       0       0       0       0
 - esr           0       0       0       0       0       0       0

Affected platform: Windows
Closing because no crashes reported for 12 weeks.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → WONTFIX
Closing because no crashes reported for 12 weeks.
There are still some crashes so reopen it.
You need to log in before you can comment on or make changes to this bug.