1212176 - Remove arguments provided to MediaDataDemuxer::NotifyDataArrived

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

NotifyDataArrived is an extremely unreliable mechanism to parse data.

When playing a plain video or audio file (such as MP3 or demuxer), the MDSM will typically start downloading the file to determine the download bitrate.

This causes the associated MediaResource to fire NotifyDataArrived before the MediaDataDemuxer has even been initialized.
If the file was small enough, it would be entirely cached before the MediaFormatReader attempts to use the demuxer and no NotifyDataArrived would even be called on the demuxer.

We should make it clearer by making the description of MediaDataDemuxer::NotifyDataArrived more explicit, and even remove the arguments as they ultimately serve no purpose being so unreliable.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Remove arguments passed to MediaDataDemuxer::NotifyDataArrived API.

Be more explicit on what it does and how it should be used.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af903bae2619

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af903bae2619