1212197 - not clear how to r+ a commit without adding any comments to it

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Cameron McCormack (:heycam)]

I wanted to r+ a commit in a multi-commit review.  It wasn't clear to me how to do this.  I discovered clicking "Finish review" in the top bar opened a dialog for the currently selected commit, on which there was the "Ship it" button.  I thought the buttons in that bar applied to the whole bug's reviews, not the individual commit I had selected.

I think in general it is not clear whether you are looking at an individual commit or the whole bug's review.  It's also not clear that that brown bar of buttons applies only to the selected commit and not the whole bug.

Comment 1

[Cameron McCormack (:heycam)]

To be clear, I wanted to r+ a commit without adding any line comments to it.

Comment 2

[Gregory Szorc [:gps]]

There used to be a "Ship It" button that did this. However, multiple people were clicking it and were upset it submitted the review without giving them an opportunity to leave non-line comments. So we simplified the UI by removing that button and required a dialog before any changes were actually submitted. See bug 1195860.

Any future work in this area will likely focus on making the "what happens when I submit this review" bit more obvious and this bug will likely get duped. I don't think we can bring back the "r+ without adding any comments button" because people will click it unknowingly and will be upset that they did.

Comment 3

[Cameron McCormack (:heycam)]

I was actually concerned that "Finish review" would push the entire review without a chance at me setting r+ on the commit I was looking at. :-)  I look forward to the future "what happens when I submit this review" obviousness improvements.

Comment 4

[Gregory Szorc [:gps]]

I can see that. Perhaps if we put a "..." or some kind of icon on the links to indicate they will open a dialog.

mdoglio: Interested in whipping something up? https://hg.mozilla.org/hgcustom/version-control-tools/rev/df94ce32c5b0 is where we last changed this.

Comment 5

[Cameron McCormack (:heycam)]

(In reply to Gregory Szorc [:gps] from comment #4)
> I can see that. Perhaps if we put a "..." or some kind of icon on the links
> to indicate they will open a dialog.

Sounds like a good interim solution, thanks.

Comment 6

[Mauro Doglio [:mdoglio]]

I'm taking this

Comment 7

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: mozreview: add ellipses to `finish review` (bug 1212197); r?gps

mozreview: add ellipses to `finish review` (bug 1212197); r?gps

Comment 8

[Mauro Doglio [:mdoglio]]

I added a second screenshot to the review request with an alternative wording.

Comment 9

[Mauro Doglio [:mdoglio]]

Comment on attachment 8673172 [details]
MozReview Request: mozreview: add ellipses to `finish review` (bug 1212197); r?gps

mozreview: always pass the current user when getting a draft (bug 1212197); r?smacleod

Comment 10

[Mauro Doglio [:mdoglio]]

Comment on attachment 8673172 [details]
MozReview Request: mozreview: add ellipses to `finish review` (bug 1212197); r?gps

mozreview: add ellipses to `finish review` (bug 1212197); r?gps

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8673172 [details]
MozReview Request: mozreview: add ellipses to `finish review` (bug 1212197); r?gps

https://reviewboard.mozilla.org/r/21855/#review19649

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/01ecad724f27e1487f02b3aee49218953104a90e
mozreview: add ellipses to `finish review` (bug 1212197); r=gps