1212272 - "make dist" for the Loop standalone doesn't update the css and supplementary files properly

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

I just happened to look at the dev server, and noticed that the ToS looked wrong on the standalone page. Investigation showed it had an out-of-date css compared to what was on mozilla-central.

Digging deeper, I found that content/ was fine, but dist/ was out-of-date for the css. I also then found there was an additional dist/content directory with up-to-date css.

The problem is with `cp -pr content dist` - it'll copy content to within dist if dist already exists.

I have a patch coming up to fix this.

Comment 1

[Mark Banner (:standard8)]

Attachment: 'make dist' for the Loop standalone doesn't update the css and supplementary files properly.

This swaps us to use content/* -> dist which always gets it right, and also optionally creates the dist directory if it doesn't exist.

I've swapped to -R for cp as on Mac the man page says (and on the dev server it supports both):

"""
Historic versions of the cp utility had a -r option.  This implementation supports that option; however, its use is strongly discouraged, as it does not correctly copy special files, symbolic links, or fifo's.
"""

Comment 2

[Mark Banner (:standard8)]

(Note: high prio as this was affecting QA and could affect releases).

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8670706 [details] [diff] [review]
'make dist' for the Loop standalone doesn't update the css and supplementary files properly.

Review of attachment 8670706 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix, r=dmose

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f2f2d80d4ab4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2f2d80d4ab4

Comment 6

[Mark Banner (:standard8)]

Unfortunately I failed to port the patch correctly...

Comment 7

[Mark Banner (:standard8)]

Attachment: Follow-up to bug 1212272 - use the correct cp command.

This uses the proper copy command that I'd tested before and didn't port across properly :-(

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8671484 [details] [diff] [review]
Follow-up to bug 1212272 - use the correct cp command.

Review of attachment 8671484 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e5dd1d0bae2c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5dd1d0bae2c