"make dist" for the Loop standalone doesn't update the css and supplementary files properly

RESOLVED FIXED in Firefox 44

Status

P1
normal
Rank:
5
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla44
Points:
2

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
I just happened to look at the dev server, and noticed that the ToS looked wrong on the standalone page. Investigation showed it had an out-of-date css compared to what was on mozilla-central.

Digging deeper, I found that content/ was fine, but dist/ was out-of-date for the css. I also then found there was an additional dist/content directory with up-to-date css.

The problem is with `cp -pr content dist` - it'll copy content to within dist if dist already exists.

I have a patch coming up to fix this.
(Assignee)

Comment 1

3 years ago
Created attachment 8670706 [details] [diff] [review]
'make dist' for the Loop standalone doesn't update the css and supplementary files properly.

This swaps us to use content/* -> dist which always gets it right, and also optionally creates the dist directory if it doesn't exist.

I've swapped to -R for cp as on Mac the man page says (and on the dev server it supports both):

"""
Historic versions of the cp utility had a -r option.  This implementation supports that option; however, its use is strongly discouraged, as it does not correctly copy special files, symbolic links, or fifo's.
"""
Attachment #8670706 - Flags: review?(dmose)
(Assignee)

Comment 2

3 years ago
(Note: high prio as this was affecting QA and could affect releases).
Iteration: --- → 44.2 - Oct 19
Points: --- → 2
Rank: 5
Comment on attachment 8670706 [details] [diff] [review]
'make dist' for the Loop standalone doesn't update the css and supplementary files properly.

Review of attachment 8670706 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix, r=dmose
Attachment #8670706 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/f2f2d80d4ab4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Comment 6

3 years ago
Unfortunately I failed to port the patch correctly...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

3 years ago
Created attachment 8671484 [details] [diff] [review]
Follow-up to bug 1212272 - use the correct cp command.

This uses the proper copy command that I'd tested before and didn't port across properly :-(
Attachment #8671484 - Flags: review?(dmose)
Comment on attachment 8671484 [details] [diff] [review]
Follow-up to bug 1212272 - use the correct cp command.

Review of attachment 8671484 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose
Attachment #8671484 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/e5dd1d0bae2c
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.