Closed Bug 1212319 Opened 4 years ago Closed 4 years ago

Add docs for Worker markers

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: vporof, Assigned: vporof)

Details

(Whiteboard: [polish-backlog] [difficulty=easy])

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
As per https://bugzilla.mozilla.org/show_bug.cgi?id=1211838#c4
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8670771 - Flags: review?(jsantell)
Comment on attachment 8670771 [details] [diff] [review]
v1

Review of attachment 8670771 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/performance/docs/markers.md
@@ +149,5 @@
> +
> +Emitted whenever there's an operation dealing with Workers (any kind of worker,
> +Web Workers, Service Workers etc.). Currently there are 4 types of operations
> +being tracked: serializing/deserializing data on the main thread, and also
> +serializing/deserializing data off the main thread.

Needs type, name and description of this marker's properties, as well as a link or description to the corresponding enums. These describe markers /coming from the actor/, and I had to look up the worker marker patch's tests to see what additional properties were here:

* unsigned short workerOperation

Check out the `## Styles` entry. R+ with types and descriptions of the properties
Attachment #8670771 - Flags: review?(jsantell) → review+
Attached patch v2 (obsolete) — Splinter Review
Addressed comments.
Attachment #8670771 - Attachment is obsolete: true
Attachment #8671884 - Flags: review+
Whiteboard: [polish-backlog] [difficulty=easy]
Attached patch v3Splinter Review
Rebased.
Attachment #8671884 - Attachment is obsolete: true
Attachment #8678145 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/31953d67322e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.