1212325 - [Contacts] When going to settings in the console log we can see an error message.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

- Launch contacts, with adb logcat enabled.
- Quickly press on the settings button several times.

You'll observer in the console the following:

E/Communications( 9471): [JavaScript Error: "ReferenceError: ImportStatusData is not defined" {file: "app://communications.gaiamobile.org/shared/js/contacts/import/utilities/misc.js" line: 18}]

And the settings panel doesn't open. After 3-4 seconds (I think is when navigation ready event is fired) we can press the settings button and access settings without this error.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:
Bad user experience, the settings button takes too long to be accessible, and we have an error being output to the console.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comms triage: Bad user experience. Depending on how many contacts you have, being able to go to settings can take 3+ seconds, whereas the button is enabled.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1212325 > mozilla-b2g:master

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8671474 [details] [review]
[gaia] arcturus:bug-1212325 > mozilla-b2g:master

Ensuring that we have all the dependencies loaded when we go to settings.

We were lucky cause after performing the deferred actions, that is waiting until we load all contacts, we were loading the dependency.

Now we load (if not being loaded before) when we need it for settings.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/362b0df924eba57c9abb7f9454fdf685accba4d6

and nga:

https://github.com/mozilla-b2g/gaia/commit/e3205803119071f6ae8b0ab947ecb0f59a94043f