1212340 - Move the Leave feedback option from the conversation window settings menu to the panel settings menu.

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

As part of the user journey rework, we need to move the leave feedback option. This depends on bug 1212338 to avoid code bitrot.

See the user story for more detail.

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Move the Leave feedback option from the conversation window settings menu to the panel settings menu.

Mark, could you review the patch when you get a chance?

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8673599 [details] [diff] [review]
Move the Leave feedback option from the conversation window settings menu to the panel settings menu.

Review of attachment 8673599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, just a couple of minor nits to fix up.

::: browser/components/loop/content/js/panel.jsx
@@ +272,5 @@
>                                     onClick={this.handleClickSettingsEntry} />
>              <SettingsDropdownEntry label={mozL10n.get("tour_label")}
>                                     onClick={this.openGettingStartedTour} />
> +            <SettingsDropdownEntry
> +                                   extraCSSClass="entry-settings-feedback"

nit: please put these on the same line.

::: browser/components/loop/test/desktop-local/panel_test.js
@@ +445,5 @@
> +      }
> +
> +      beforeEach(function() {
> +        feedbackUrl = "https://example.com";
> +        navigator.mozLoop.getLoopPref = function(pref) {

Please use fakeMozLoop.getLoopPref

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f65bfc6d9898

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f65bfc6d9898

Comment 6

[Bogdan Maris, Desktop QA]

We did some exploratory testing around following the acceptance criteria using Firefox 44 beta 2 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 64-bit) and can confirm that the changes are verified as fixed.