Closed
Bug 1212343
Opened 9 years ago
Closed 9 years ago
Propagate OOM from SafepointWriter
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.85 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Is this the same as the issue you found?
Attachment #8670792 -
Flags: feedback?(nicolas.b.pierron)
Comment 2•9 years ago
|
||
(In reply to Jon Coppeard (:jonco) from comment #1) > Is this the same as the issue you found? No, this is not the same, I guess you land this fix too.
Comment 3•9 years ago
|
||
Comment on attachment 8670792 [details] [diff] [review] ion-safepoint-oom Review of attachment 8670792 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/TypeInference.cpp @@ +4338,5 @@ > if (output.isValid()) { > JSScript* script = output.script(); > if (IsAboutToBeFinalizedUnbarriered(&script)) { > + if (script->hasIonScript()) > + script->ionScript()->recompileInfoRef() = RecompileInfo(); Can you explain me how this is related to the previous change?
Attachment #8670792 -
Flags: feedback?(nicolas.b.pierron) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Nicolas B. Pierron [:nbp] from comment #3) > Can you explain me how this is related to the previous change? Not related, but also necessary for the testcase to pass. script->hasIonScript() can be false here (I assume due to OOM failure during construction) so calling script->ionScript() could assert.
Assignee | ||
Comment 5•9 years ago
|
||
Testcase is still failing on arm simulator builds.
Assignee | ||
Comment 6•9 years ago
|
||
Failure was fixed by bug 1130672.
The test this patch adds is failing on at least osx debug: https://treeherder.mozilla.org/logviewer.html#?job_id=15408745&repo=mozilla-inbound Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/bf388a8e620b
Flags: needinfo?(jcoppeard)
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/90e53950660e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(jcoppeard)
You need to log in
before you can comment on or make changes to this bug.
Description
•