Closed Bug 1212343 Opened 6 years ago Closed 6 years ago

Propagate OOM from SafepointWriter

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Is this the same as the issue you found?
Attachment #8670792 - Flags: feedback?(nicolas.b.pierron)
(In reply to Jon Coppeard (:jonco) from comment #1)
> Is this the same as the issue you found?

No, this is not the same, I guess you  land this fix too.
Comment on attachment 8670792 [details] [diff] [review]
ion-safepoint-oom

Review of attachment 8670792 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/TypeInference.cpp
@@ +4338,5 @@
>              if (output.isValid()) {
>                  JSScript* script = output.script();
>                  if (IsAboutToBeFinalizedUnbarriered(&script)) {
> +                    if (script->hasIonScript())
> +                        script->ionScript()->recompileInfoRef() = RecompileInfo();

Can you explain me how this is related to the previous change?
Attachment #8670792 - Flags: feedback?(nicolas.b.pierron) → review+
(In reply to Nicolas B. Pierron [:nbp] from comment #3)

> Can you explain me how this is related to the previous change?

Not related, but also necessary for the testcase to pass.  script->hasIonScript() can be false here (I assume due to OOM failure during construction) so calling script->ionScript() could assert.
Testcase is still failing on arm simulator builds.
Failure was fixed by bug 1130672.
https://hg.mozilla.org/mozilla-central/rev/90e53950660e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Flags: needinfo?(jcoppeard)
You need to log in before you can comment on or make changes to this bug.