Closed
Bug 1212348
Opened 9 years ago
Closed 9 years ago
The RoomList view requires user profile data passed in when it doesn't need to
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox44 fixed)
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [tech-debt])
Attachments
(1 file)
8.14 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
It used to be that in creating a room we needed the user profile data, as part of that would affect room creation. However, this was removed a while ago, but it seems we left in some of the props and functions surrounding it. We should just drop them (this will also simplify some of the likely bitrot dependencies for the user journey code).
Assignee | ||
Comment 1•9 years ago
|
||
This just removes the dead code.
Attachment #8670801 -
Flags: review?(mdeboer)
Updated•9 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8670801 [details] [diff] [review] Loop's RoomList view requires user profile data passed in when it doesn't need to. Review of attachment 8670801 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! Thanks!
Attachment #8670801 -
Flags: review?(mdeboer) → review+
Updated•9 years ago
|
Rank: 9
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/8c65c587460e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•