The RoomList view requires user profile data passed in when it doesn't need to

RESOLVED FIXED in Firefox 44

Status

Hello (Loop)
Client
P1
normal
Rank:
9
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla44
Points:
1

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
It used to be that in creating a room we needed the user profile data, as part of that would affect room creation.

However, this was removed a while ago, but it seems we left in some of the props and functions surrounding it.

We should just drop them (this will also simplify some of the likely bitrot dependencies for the user journey code).
(Assignee)

Comment 1

2 years ago
Created attachment 8670801 [details] [diff] [review]
Loop's RoomList view requires user profile data passed in when it doesn't need to.

This just removes the dead code.
Attachment #8670801 - Flags: review?(mdeboer)
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Comment on attachment 8670801 [details] [diff] [review]
Loop's RoomList view requires user profile data passed in when it doesn't need to.

Review of attachment 8670801 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks!
Attachment #8670801 - Flags: review?(mdeboer) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/8c65c587460e

Updated

2 years ago
Rank: 9
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/8c65c587460e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.