Closed Bug 1212399 Opened 4 years ago Closed 4 years ago

Re-introduce better .toolbarbutton-1 styling for dark themes

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox43 --- verified
firefox44 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

I implemented this in bug 1173743 but removed it in bug 1173744. See bug 1173744 comment 18.
Blocks: 1022560
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8670973 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8670973 [details] [diff] [review]
patch

Review of attachment 8670973 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8670973 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/28a0a90ea90a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Flags: qe-verify+
Comment on attachment 8670973 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1173743 / bug 1173744
[User impact if declined]: See bug 1173744 comment 18
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: very straightforward CSS changes, low risk
[String/UUID change made/needed]:
Attachment #8670973 - Flags: approval-mozilla-aurora?
Comment on attachment 8670973 [details] [diff] [review]
patch

Minor css fix to increase UI contrast, ok to uplift to aurora.
Attachment #8670973 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hi, this cause problems uplifting to aurora 

grafting 307827:28a0a90ea90a "Bug 1212399 - Re-introduce better .toolbarbutton-1 styling for dark themes. r=gijs"
merging browser/themes/windows/browser.css
warning: conflicts during merge.
merging browser/themes/windows/browser.css incomplete! (edit conflicts, then use 'hg resolve --mark')
Flags: needinfo?(dao)
Bug 1173744 needs to be uplifted first.
Flags: needinfo?(dao)
(In reply to Dão Gottwald [:dao] from comment #8)
> Bug 1173744 needs to be uplifted first.

liz, could you take a look at this, seems bug 1173744 needs to be decided first re: approvals for aurora
Flags: needinfo?(lhenry)
Confirming this fix on Windows 7 64-bit and Windows 10 32-bit using latest Nightly, build ID: 20151015030233.
Status: RESOLVED → VERIFIED
Also verified as fixed on latest Aurora, build ID: 20151022004116.
Testing was performed on the same OSs mentioned in comment 10.
You need to log in before you can comment on or make changes to this bug.