mozilla license doesn't work in .xul or .dtd files

VERIFIED FIXED in M10

Status

()

Core
XUL
P3
critical
VERIFIED FIXED
19 years ago
10 years ago

People

(Reporter: Brade, Assigned: dmose)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
Yesterday I took a few minutes to add the mozilla license to all of the xul, css,
js, and dtd files in the editor ui.  To my dismay I completely broke the editor
and all of its dialogs (none of them would load--I just get tiny windows).

Apparently adding the license (found at http://www.mozilla.org/NPL/boilerplate-
1.1/npl.html) to the beginning of each file doesn't work.  For now, I have backed
out the license in all of the *.xul, and *.dtd files.

I'm not sure who this bug should go to (parser or xul problem).  Please reassign
if appropriate.
(Assignee)

Comment 1

19 years ago
One interesting thing about XML (and thus xul and presumably dtd) is that the
first line in an XML file must be the <?xml version="1.0"?> or similar tag.  So
the license text would have to start at least on the second line.  It may in
fact be that the license boilerplat has to follow all the <? tags; I don't
know.  Perhaps someone who knows XML better can fill me in.

Could this have been the problem you were seeing, Kathy?

Dan

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → INVALID

Comment 2

19 years ago
XML has strict well-formedness rules.  The first line has to be the xml 1.0
thing.  It has to come first.
(Reporter)

Updated

19 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 3

19 years ago
Sorry my first stab at the bug wasn't clearer.  I added the license starting at
line 2 (after the <?xml ... line)
(Reporter)

Updated

19 years ago
Resolution: INVALID → ---
(Reporter)

Comment 4

19 years ago
clear resolution
note: it doesn't matter if it's below the doctype line; testing more
variations...
(Reporter)

Comment 5

19 years ago
I added the license comment to the end of the xul file... still doesn't work

Comment 6

19 years ago
You are using <!-- and -->, right?
(Reporter)

Updated

19 years ago
Assignee: hyatt → dmose
Status: REOPENED → NEW
(Reporter)

Comment 7

19 years ago
rats I lost my comment earlier
reassign to dmose@mozilla.org

from the xml spec:  For compatibility, the string "--" (double-hyphen) must not
occur within comments.
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

19 years ago
I've reformatted the *.html comments in the boilerplate a bit, so they should
no longer violate XML comment rules.

Updated

19 years ago
Whiteboard: Back to engineer for verification...

Comment 9

19 years ago
Kathy, could you verify this?  Thanks!
-Chris
(Reporter)

Updated

19 years ago
Whiteboard: Back to engineer for verification... → Back to engineer for verification...bounce back to QA
Target Milestone: M10
(Reporter)

Comment 10

19 years ago
There shouldn't be any reason why you can't verify this (it's not in the code).
Just create a xul file and add the license to it.  The new license will work.
The old license had "  --" at the beginning of most of its lines (you could test)
which wouldn't work.

The url for the license is listed in the comments above.

Comment 11

19 years ago
Low regression priority.  Will regress after other bugs.
(Reporter)

Updated

19 years ago
Status: RESOLVED → VERIFIED
Whiteboard: Back to engineer for verification...bounce back to QA

Comment 12

19 years ago
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.