12126 - Removing "bgcolor" attribute from BODY tag doesn't trigger repaint

Status: VERIFIED DUPLICATE of bug 1886

(Core :: Layout, defect, P3)

Description

[kinmoz]

nsHTMLEditor::SetBackgroundColor() does not use a transaction to set the bgcolor
attribute on the body. It needs to if we want to be able to undo this action.

I believe all that needs to be done is to call SetBodyAttribute()?

Comment 1

[Simon Fraser [no longer active]]

charlie implemented this, so I'll let him handle it.

Comment 2

[Charles Manske]

*** Bug 11773 has been marked as a duplicate of this bug. ***

Comment 3

[kinmoz]

Charlie, I think what we need to do here is get rid of SetBackgroundColor() from
all our interfaces and just have the JavaScript call SetBodyAttribute().

SetBodyAttribute() goes through the transaction system I believe.

Comment 4

[Charles Manske]

But this method sets (i.e, will set) table backgrounds when that is
appropriate. Although I guess the logic to check if you are in a table could
also be done in JS. I just need to use nsHTMLEditor::SetAttribute instead.

Comment 5

[Charles Manske]

Checked in 8/25

Comment 6

[sujay]

not fixed...both Kin and I saw that undoing a bg change didn't work...

Comment 7

[sujay]

forgot to add that it was the 9/2 build that we noticed it wasn't fixed..

Comment 8

[Charles Manske]

Well I'm using the nsEditor::SetAttribute() method that goes through the
transaction system and it worked after I first tested it, but it doesn't seem
to undo now. Must be another problem.

Comment 9

[Charles Manske]

I updated my tree as of 9/2/99 mid afternoon and it works fine.
I used File|New from the browser to create a new editor document, typed in it,
and tested both File|Close and File|Quit and in both cases it brought up a
dialog asking you to save. It also worked from the default editor page, after
typing in it.

Comment 10

[sujay]

Charley, I tried undo'ing after changing the bg color...still not working
using 9/17 builds...you wanted me to check this out....

Comment 11

[Charles Manske]

This one has been mysterious!
The problem is this:
When setting the color, the current value of "bgcolor" is saved, as well as
a bool that the attribute is set. This is used to undo the action.
The problem is this: When using the Set Background color the first time,
then undoing, the undo action correctly removes the "bgcolor" attribute, but
the document isn't repainted.
You can use the test file to confirm this:
1. Load the test page
2. Click on the "Set Background Red" button JUST ONCE. (you have to resize the
windo for the complete background to be repainted - that is a separate bug.)
3. Click on "Remove..." button to remove the bgcolor attribute. Resizing
doesn't clear the red background.

Comment 12

[Charles Manske]

Attachment: Test setting and removing the "bgcolor" attribute on BODY tag

Comment 13

[troy]

*** This bug has been marked as a duplicate of 1886 ***

Comment 14

[sujay]

verified in 12/7 build.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0bce5395e18
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12126 - Tab counter consumeFrom update