1212618 - unknownContentType.xul grows size when toggling the "Do this for all files"

Status: RESOLVED DUPLICATE of bug 1211344

(Toolkit :: Downloads API, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: lol.mov

Haven't tried in other platforms, but this is on OSX Yosemite. Watch the attached screen recording.

STR:
 - Open a link that forces a download, such as the attachment on this bug
 - Check/Uncheck the "Do this for all files" checkbox
 - Hilarity ensues

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I reproduced it on Windows.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Without digging deep in to why dialog.sizeToContent is causing the wrong result to be concluded, I've changed this to not resize the dialog anymore but to make the text not visible until the textbox is checked (changing visibility instead of display).

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8671445 [details] [diff] [review]
Patch

Review of attachment 8671445 [details] [diff] [review]:
-----------------------------------------------------------------

settingsChange has the hidden="true" from the markup at unknownContentType.xul, which needs to be cleared or changed to style="visibility: hidden"

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yikes! That's what I get for writing the patch while doing a clobber build!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

I went with style="visibility:hidden;" because toggleRememberChoice() isn't called in all code paths of initDialog. Also, there isn't a content stylesheet which is where I would have wanted to put it and this didn't seem like a large enough bug to introduce a content stylesheet for.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b78c1b06764c

Comment 7

[[e-mail]]

(In reply to Jared Wein from comment #2)
> Without digging deep in to why dialog.sizeToContent is causing the wrong
> result to be concluded

Bug 1211344.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

I backed this out in favor of bug 1211344
https://hg.mozilla.org/integration/fx-team/rev/b142c073ea28