[Rule View] Clicking a search button next to overridden properties scrolls to incorrect position

NEW
Unassigned

Status

P3
enhancement
3 years ago
2 months ago

People

(Reporter: dmattia, Unassigned)

Tracking

43 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8671042 [details]
Screen Shot 2015-10-07 at 5.31.09 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36

Steps to reproduce:

When looking at unused rules in the far right css tab, I clicked the search button next to a crossed out rule.


Actual results:

All occurrences of the rule were highlighted, but I was jumped to another crossed out rule. The screenshot shows the rule I was jumped to.


Expected results:

All occurrences of the rule are highlighted, and I would have jumped to the used rule.
Some more info from talk on IRC.

Detailed steps here (different case for the screenshot):
1. open https://www.mozilla.org/en-US/
2. inspect the word "privacy" in the "commited to you, your privacy and an open web" section
3. in rule view, scroll down to the "h1, h2, h3, h4, h5, h6, legend, .huge, .large, legend" section
4. in the section, click the search button next to crossed out "font-family" rule

Applying filter changes the entire height of the content in rule view, but there seems no code to scroll to any rule after clicking the button.  So, if there are many rules and rule view doesn't have enough height to display them without scroll before/after filtering,  it displays another crossed out rule after filtering (in many case, it's scrolled to the bottom, because of decreased content height, I think).

It would be nice to scroll to either clicked or used rule.

May be related to following comment in bug 1151943

(In reply to Brian Grinstead [:bgrins] from bug 1151943 comment #23)
> For instance, the scroll location is lost when clicking a mag glass and then
> pressing ESC - we may want to maintain the original position before a search
> starts and then restore it when the textbox becomes empty, which could be a
> general improvement for search.
Status: UNCONFIRMED → NEW
Component: Untriaged → Developer Tools: Inspector
Ever confirmed: true
Summary: inspect element search brings up incorrect rule → [Rule View] Clicing a search button next to overridden properties scrolls to incorrect position
Someone comment in #developers today about working on this bug.  If you're interested in that, please comment here and we can provide more detail.

In general, #devtools is a good place to discuss the tools.  Also, https://wiki.mozilla.org/DevTools/Hacking gives an overview of working with the code.
(Reporter)

Comment 3

3 years ago
I am interested in working on this bug. That was me in #developers :)

Updated

3 years ago
Summary: [Rule View] Clicing a search button next to overridden properties scrolls to incorrect position → [Rule View] Clicking a search button next to overridden properties scrolls to incorrect position
Filter on CLIMBING SHOES
Severity: normal → enhancement
Priority: -- → P3

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.