Created attachment 8671116 [details] [diff] [review] 0001-Bug-XXXXXXX-have-about-sync-tabs-reload-the-new-set-.patch It looks like it tries to, but fails for a number of reasons. STR: * ensure you have sync setup such that after manually performing a sync, about:sync-tabs shows some remote tabs. * restart the browser and open about:sync-tabs *before* the first sync (ie, withing the first 10 seconds) - note about:sync-tabs is blank as we don't have the set of remote tabs yet. * force (or wait for) a sync Expected: * the blank about:sync-tabs has updated to show the tabs we now know about. Actual: * it remains blank. This patch addresses the following problems: * it observes that an engine sync is complete, but checks |subject| for the name of the engine - the engine name is sent in |data|. * The inline "onComplete" function is called such that |this| in the function is not the correct object when called bu the nextTick() function. * The |force| param to |buildList()| was setup to specify whether a new Sync should be forced or not - but if this param was false, it still didn't actually rebuild the list using the most recently available data. I've renamed that param to |forceSync| and it now rebuilds the UI even if it didn't force a sync.
Attachment #8671116 - Flags: review?(adw)
Attachment #8671116 - Flags: review?(adw) → review+
Iteration: --- → 44.2 - Oct 19
Priority: -- → P1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
QA Contact: paul.silaghi
Reproduced the issue on Nightly 2015-09-18. Verified fixed FF 44.0a1 (2015-10-21) Win 7.
Status: RESOLVED → VERIFIED
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.